[PATCH] mlx4: Performing SENSE_PORT command only when supported
From: Yevgeny Petrilin <hidden>
Date: 2011-05-04 13:38:49
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Not all HW supports this functionality, and in this case FW would report command error. This patch checks this capability before trying to sense link partner. Signed-off-by: Yevgeny Petrilin <redacted> --- drivers/net/mlx4/main.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c
index 3814fc9..f47ac5a 100644
--- a/drivers/net/mlx4/main.c
+++ b/drivers/net/mlx4/main.c@@ -944,10 +944,12 @@ static int mlx4_setup_hca(struct mlx4_dev *dev) } for (port = 1; port <= dev->caps.num_ports; port++) { - enum mlx4_port_type port_type = 0; - mlx4_SENSE_PORT(dev, port, &port_type); - if (port_type) - dev->caps.port_type[port] = port_type; + if (dev->caps.flags & MLX4_DEV_CAP_FLAG_DPDP) { + enum mlx4_port_type port_type = 0; + mlx4_SENSE_PORT(dev, port, &port_type); + if (port_type) + dev->caps.port_type[port] = port_type; + } ib_port_default_caps = 0; err = mlx4_get_port_ib_caps(dev, port, &ib_port_default_caps); if (err)
--
1.6.0.2