3 messages, 3 authors, 2011-03-18 · open the first message on its own page
From: Jeffrin Jose <hidden>
Date: 2011-03-18 18:35:40
hello , I have created a patch for net/ipv4/icmp.c using checkpatch.pl script to fix several warnings and an error. I have attached the patch along with this mail. /Thanks -- software engineer. department of computer science rajagiri school of engineering and technology.
From: Ben Hutchings <hidden>
Date: 2011-03-18 19:41:16
On Sat, 2011-03-19 at 00:05 +0530, Jeffrin Jose wrote:
hello , I have created a patch for net/ipv4/icmp.c using checkpatch.pl script to fix several warnings and an error.
You need to learn C programming before trying to correct C programs. You should not just do what it takes to make checkpatch.pl happy. Ben.
I have attached the patch along with this mail. /Thanks
-- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.
From: David Miller <davem@davemloft.net>
Date: 2011-03-18 19:56:52
From: Ben Hutchings <redacted> Date: Fri, 18 Mar 2011 19:41:01 +0000
On Sat, 2011-03-19 at 00:05 +0530, Jeffrin Jose wrote:quoted
hello , I have created a patch for net/ipv4/icmp.c using checkpatch.pl script to fix several warnings and an error.You need to learn C programming before trying to correct C programs. You should not just do what it takes to make checkpatch.pl happy.
I completely agree, and I absolutely refuse to apply this patch.