[patch] ariadne: remove redundant NULL check

STALE5661d

4 messages, 3 authors, 2011-03-11 · open the first message on its own page

[patch] ariadne: remove redundant NULL check

From: <hidden>
Date: 2011-03-10 22:36:43

Simply remove redundant 'dev' NULL check.
Source code uses spaces instead of TAB, except 'printk' and 'return' lines.


Signed-off-by: Jinqiu Yang <redacted>
---
 ariadne.c |    5 -----
 1 file changed, 5 deletions(-)
--- a/drivers/net/ariadne.c	2011-03-10 11:20:14.076039323 -0500
+++ b/drivers/net/ariadne.c	2011-03-10 11:21:59.111164537 -0500
@@ -425,11 +425,6 @@ static irqreturn_t ariadne_interrupt(int
     int csr0, boguscnt;
     int handled = 0;
 
-    if (dev == NULL) {
-	printk(KERN_WARNING "ariadne_interrupt(): irq for unknown device.\n");
-	return IRQ_NONE;
-    }
-
     lance->RAP = CSR0;			/* PCnet-ISA Controller Status */
 
     if (!(lance->RDP & INTR))		/* Check if any interrupt has been */

Re: [patch] ariadne: remove redundant NULL check

From: David Miller <davem@davemloft.net>
Date: 2011-03-10 22:39:08

From: j223yang@asset.uwaterloo.ca
Date: Thu, 10 Mar 2011 17:36:37 -0500
Simply remove redundant 'dev' NULL check.
Source code uses spaces instead of TAB, except 'printk' and 'return' lines.


Signed-off-by: Jinqiu Yang <redacted>
Patch is still corrupted by your email client, the same way as before.
And when you fix it, you don't need to mention this in the commit
message.

Please, take the time to do some testing by sending the patch to
yourself, and then try to apply the patch in the email you receive.

Re: [patch] ariadne: remove redundant NULL check

From: David Miller <davem@davemloft.net>
Date: 2011-03-10 22:39:58

From: David Miller <davem@davemloft.net>
Date: Thu, 10 Mar 2011 14:39:42 -0800 (PST)
From: j223yang@asset.uwaterloo.ca
Date: Thu, 10 Mar 2011 17:36:37 -0500
quoted
Simply remove redundant 'dev' NULL check.
Source code uses spaces instead of TAB, except 'printk' and 'return' lines.


Signed-off-by: Jinqiu Yang <redacted>
Patch is still corrupted by your email client, the same way as before.
Sorry, I apologize, this is not your fault.

This is one of those terrible old drivers that have bad coding
style.

I'll apply this patch, thank you.

Re: [patch] ariadne: remove redundant NULL check

From: Nicolas Kaiser <hidden>
Date: 2011-03-11 09:59:10

* David Miller [off-list ref]:
This is one of those terrible old drivers that have bad coding
style.
Would you like a cleanup patch for this driver?

Best regards,
Nicolas Kaiser
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help