[PATCH] mlx4_en: Removing HW info from ethtool -i report.

Subsystems: networking drivers, the rest

STALE5659d

2 messages, 2 authors, 2011-03-24 · open the first message on its own page

[PATCH] mlx4_en: Removing HW info from ethtool -i report.

From: Yevgeny Petrilin <hidden>
Date: 2011-03-24 08:36:30

Avoiding abuse of ethtool_drvinfo.driver field.
HW specific info can be retrieved using lspci.

Signed-off-by: Yevgeny Petrilin <redacted>
---
 drivers/net/mlx4/en_ethtool.c |   15 +--------------
 1 files changed, 1 insertions(+), 14 deletions(-)
diff --git a/drivers/net/mlx4/en_ethtool.c b/drivers/net/mlx4/en_ethtool.c
index 62ace6c..d54b7ab 100644
--- a/drivers/net/mlx4/en_ethtool.c
+++ b/drivers/net/mlx4/en_ethtool.c
@@ -45,20 +45,7 @@ mlx4_en_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *drvinfo)
 	struct mlx4_en_priv *priv = netdev_priv(dev);
 	struct mlx4_en_dev *mdev = priv->mdev;
 
-	switch (mdev->dev->rev_id) {
-	case 0xa0:
-		if (dev->dev_id >= MLX4_EN_CX3_LOW_ID && dev->dev_id <= MLX4_EN_CX3_HIGH_ID)
-			sprintf(drvinfo->driver, DRV_NAME " (%s_CX-3)", mdev->dev->board_id);
-		else
-			sprintf(drvinfo->driver, DRV_NAME " (%s_CX)", mdev->dev->board_id);
-		break;
-	case 0xb0:
-		sprintf(drvinfo->driver, DRV_NAME " (%s_CX-2)", mdev->dev->board_id);
-		break;
-	default:
-		sprintf(drvinfo->driver, DRV_NAME " (%s)", mdev->dev->board_id);
-		break;
-	}
+	strncpy(drvinfo->driver, DRV_NAME, 32);
 	strncpy(drvinfo->version, DRV_VERSION " (" DRV_RELDATE ")", 32);
 	sprintf(drvinfo->fw_version, "%d.%d.%d",
 		(u16) (mdev->dev->caps.fw_ver >> 32),
-- 
1.6.0.2


Re: [PATCH] mlx4_en: Removing HW info from ethtool -i report.

From: David Miller <davem@davemloft.net>
Date: 2011-03-24 18:47:22

From: Yevgeny Petrilin <redacted>
Date: Thu, 24 Mar 2011 10:36:27 +0200
Avoiding abuse of ethtool_drvinfo.driver field.
HW specific info can be retrieved using lspci.

Signed-off-by: Yevgeny Petrilin <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help