[PATCH] pktgen: fix errata in show results

Subsystems: networking [general], the rest

STALE5661d

4 messages, 2 authors, 2011-03-09 · open the first message on its own page

[PATCH] pktgen: fix errata in show results

From: Daniel Turull <hidden>
Date: 2011-03-07 09:09:47

The units in show_results in pktgen were not correct.
The results are in usec but it was displayed nsec.

Reported-by: Jong-won Lee <redacted>
Signed-off-by: Daniel Turull <redacted>
---
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index d73b77a..f0aec6c 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3271,7 +3271,7 @@ static void show_results(struct pktgen_dev 
*pkt_dev, int nr_frags)
                      pkt_dev->started_at);
      ktime_t idle = ns_to_ktime(pkt_dev->idle_acc);

-    p += sprintf(p, "OK: %llu(c%llu+d%llu) nsec, %llu (%dbyte,%dfrags)\n",
+    p += sprintf(p, "OK: %llu(c%llu+d%llu) usec, %llu (%dbyte,%dfrags)\n",
               (unsigned long long)ktime_to_us(elapsed),
               (unsigned long long)ktime_to_us(ktime_sub(elapsed, idle)),
               (unsigned long long)ktime_to_us(idle),

Re: [PATCH] pktgen: fix errata in show results

From: David Miller <davem@davemloft.net>
Date: 2011-03-07 09:19:06

From: Daniel Turull <redacted>
Date: Mon, 07 Mar 2011 10:09:43 +0100
The units in show_results in pktgen were not correct.
The results are in usec but it was displayed nsec.

Reported-by: Jong-won Lee <redacted>
Signed-off-by: Daniel Turull <redacted>
---
Your email client corrupted the patch.

Re: [PATCH] pktgen: fix errata in show results

From: Daniel Turull <hidden>
Date: 2011-03-07 09:44:44

The units in show_results in pktgen were not correct.
The results are in usec but it was displayed nsec.

Reported-by: Jong-won Lee <redacted>
Signed-off-by: Daniel Turull <redacted>
---
Here it is the new version.
Sorry for the previous mail.
Daniel

---
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index d73b77a..f0aec6c 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3271,7 +3271,7 @@ static void show_results(struct pktgen_dev *pkt_dev, int nr_frags)
 				    pkt_dev->started_at);
 	ktime_t idle = ns_to_ktime(pkt_dev->idle_acc);
 
-	p += sprintf(p, "OK: %llu(c%llu+d%llu) nsec, %llu (%dbyte,%dfrags)\n",
+	p += sprintf(p, "OK: %llu(c%llu+d%llu) usec, %llu (%dbyte,%dfrags)\n",
 		     (unsigned long long)ktime_to_us(elapsed),
 		     (unsigned long long)ktime_to_us(ktime_sub(elapsed, idle)),
 		     (unsigned long long)ktime_to_us(idle),

Re: [PATCH] pktgen: fix errata in show results

From: David Miller <davem@davemloft.net>
Date: 2011-03-09 22:10:32

From: Daniel Turull <redacted>
Date: Mon, 07 Mar 2011 10:44:40 +0100
The units in show_results in pktgen were not correct.
The results are in usec but it was displayed nsec.

Reported-by: Jong-won Lee <redacted>
Signed-off-by: Daniel Turull <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help