[PATCH] bonding: use the correct size for _simple_hash()

Subsystems: bonding driver, networking drivers, the rest

STALE5638d

2 messages, 2 authors, 2011-02-28 · open the first message on its own page

[PATCH] bonding: use the correct size for _simple_hash()

From: Amerigo Wang <hidden>
Date: 2011-02-28 09:16:34

Clearly it should be the size of ->ip_dst here.
Although this is harmless, but it still reads odd.

Signed-off-by: WANG Cong <redacted>

---
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index 5c6fba8..9bc5de3 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c
@@ -604,7 +604,7 @@ static struct slave *rlb_choose_channel(struct sk_buff *skb, struct bonding *bon
 
 	_lock_rx_hashtbl(bond);
 
-	hash_index = _simple_hash((u8 *)&arp->ip_dst, sizeof(arp->ip_src));
+	hash_index = _simple_hash((u8 *)&arp->ip_dst, sizeof(arp->ip_dst));
 	client_info = &(bond_info->rx_hashtbl[hash_index]);
 
 	if (client_info->assigned) {

Re: [PATCH] bonding: use the correct size for _simple_hash()

From: David Miller <davem@davemloft.net>
Date: 2011-02-28 21:21:13

From: Amerigo Wang <redacted>
Date: Mon, 28 Feb 2011 17:34:28 +0800
Clearly it should be the size of ->ip_dst here.
Although this is harmless, but it still reads odd.

Signed-off-by: WANG Cong <redacted>
Applied to net-next-2.6, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help