[PATCH] ServerEngines, benet: Avoid potential null deref in be_cmd_get_seeprom_data()
From: Jesper Juhl <hidden>
Date: 2011-02-03 21:28:08
Also in:
lkml
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
wrb_from_mccq() may return null, so we may crash on a null deref in be_cmd_get_seeprom_data(). This avoids that potential crash. Signed-off-by: Jesper Juhl <redacted> --- be_cmds.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c
index 0c7811f..ec4a21d 100644
--- a/drivers/net/benet/be_cmds.c
+++ b/drivers/net/benet/be_cmds.c@@ -1786,6 +1786,8 @@ int be_cmd_get_seeprom_data(struct be_adapter *adapter, spin_lock_bh(&adapter->mcc_lock); wrb = wrb_from_mccq(adapter); + if (!wrb) + return -EBUSY; req = nonemb_cmd->va; sge = nonembedded_sgl(wrb);
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.