Hi all,
After merging the final tree, today's linux-next build (sparc32 defconfig)
failed like this:
net/ipv4/fib_trie.c:98: error: redefinition of 'struct node'
Probably exposed by commit 3630b7c050d9c3564f143d595339fc06b888d6f3
("ipv4: Remove fib_hash").
Naming a struct "node" (in the face of include/linux/node.h) is a bit
hopeful. :-)
I have left this broken for now ...
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <redacted>
Date: Thu, 3 Feb 2011 15:13:09 +1100
Hi all,
After merging the final tree, today's linux-next build (sparc32 defconfig)
failed like this:
net/ipv4/fib_trie.c:98: error: redefinition of 'struct node'
Probably exposed by commit 3630b7c050d9c3564f143d595339fc06b888d6f3
("ipv4: Remove fib_hash").
Naming a struct "node" (in the face of include/linux/node.h) is a bit
hopeful. :-)
I have left this broken for now ...
This problem has existed forever, you just have only been testing
the build with fib_hash enabled instead of fib_trie.
I'm really surprised this has never been hit before. :-)
I'll fix it up, thanks for the report.
Hi Dave,
On Wed, 02 Feb 2011 20:46:06 -0800 (PST) David Miller [off-list ref] wrote:
This problem has existed forever, you just have only been testing
the build with fib_hash enabled instead of fib_trie.
All I have been doing (in this case) is a sparc32 defconfig ...
I'll fix it up, thanks for the report.
no worries
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/