[PATCH] e1000: fix sparse warning

STALE5642d

3 messages, 3 authors, 2011-02-24 · open the first message on its own page

[PATCH] e1000: fix sparse warning

From: Stephen Hemminger <hidden>
Date: 2011-02-23 18:12:06

Sparse complains because the e1000 driver is calling ioread on a pointer
not tagged as __iomem.

Signed-off-by: Stephen Hemminger <redacted>
--- a/drivers/net/e1000/e1000_osdep.h	2011-02-23 10:00:31.496097384 -0800
+++ b/drivers/net/e1000/e1000_osdep.h	2011-02-23 10:00:47.740287665 -0800
@@ -42,7 +42,8 @@
 #define GBE_CONFIG_RAM_BASE \
 	((unsigned int)(CONFIG_RAM_BASE + GBE_CONFIG_OFFSET))
 
-#define GBE_CONFIG_BASE_VIRT    phys_to_virt(GBE_CONFIG_RAM_BASE)
+#define GBE_CONFIG_BASE_VIRT \
+	((void __iomem *)phys_to_virt(GBE_CONFIG_RAM_BASE))
 
 #define GBE_CONFIG_FLASH_WRITE(base, offset, count, data) \
 	(iowrite16_rep(base + offset, data, count))

Re: [PATCH] e1000: fix sparse warning

From: Brandeburg, Jesse <hidden>
Date: 2011-02-23 18:24:11


On Wed, 23 Feb 2011, Stephen Hemminger wrote:
Sparse complains because the e1000 driver is calling ioread on a pointer
not tagged as __iomem.

Signed-off-by: Stephen Hemminger <redacted>
Seems fine, thanks Stephen.

Reviewed-by: Jesse Brandeburg <redacted>

 

Re: [PATCH] e1000: fix sparse warning

From: Jeff Kirsher <hidden>
Date: 2011-02-24 00:03:40

On Wed, 2011-02-23 at 10:12 -0800, Stephen Hemminger wrote:
Sparse complains because the e1000 driver is calling ioread on a
pointer
not tagged as __iomem.

Signed-off-by: Stephen Hemminger <redacted> 
Thanks Stephen!  I have added this patch to my queue of e1000 patches.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help