[PATCH] CAN: add controller hardware name for Softing cards

Subsystems: can network drivers, the rest

STALE5671d

4 messages, 4 authors, 2011-02-28 · open the first message on its own page

[PATCH] CAN: add controller hardware name for Softing cards

From: Kurt Van Dijck <hidden>
Date: 2011-02-21 09:04:25

I just found that the controller hardware name is not set for the Softing
driver. After this patch, "$ ip -d link show" looks nicer.

Signed-off-by: Kurt Van Dijck <redacted>
---

diff --git a/drivers/net/can/softing/softing_main.c b/drivers/net/can/softing/softing_main.c
index 5157e15..aeea9f9 100644
--- a/drivers/net/can/softing/softing_main.c
+++ b/drivers/net/can/softing/softing_main.c

@@ -633,6 +633,7 @@ static const struct net_device_ops softing_netdev_ops = {
 };
 
 static const struct can_bittiming_const softing_btr_const = {
+	.name = "softing",
 	.tseg1_min = 1,
 	.tseg1_max = 16,
 	.tseg2_min = 1,

Re: [PATCH] CAN: add controller hardware name for Softing cards

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2011-02-21 09:13:42

On 02/21/2011 10:04 AM, Kurt Van Dijck wrote:

I just found that the controller hardware name is not set for the Softing
driver. After this patch, "$ ip -d link show" looks nicer.

Signed-off-by: Kurt Van Dijck <redacted>

Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

Marc

quoted hunk

---

diff --git a/drivers/net/can/softing/softing_main.c b/drivers/net/can/softing/softing_main.c
index 5157e15..aeea9f9 100644
--- a/drivers/net/can/softing/softing_main.c
+++ b/drivers/net/can/softing/softing_main.c

@@ -633,6 +633,7 @@ static const struct net_device_ops softing_netdev_ops = {
 };
 
 static const struct can_bittiming_const softing_btr_const = {
+	.name = "softing",
 	.tseg1_min = 1,
 	.tseg1_max = 16,
 	.tseg2_min = 1,
--

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

OT: Re: [PATCH] CAN: add controller hardware name for Softing cards

From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: 2011-02-21 17:26:37

On 21.02.2011 10:13, Marc Kleine-Budde wrote:

On 02/21/2011 10:04 AM, Kurt Van Dijck wrote:

quoted

I just found that the controller hardware name is not set for the Softing
driver. After this patch, "$ ip -d link show" looks nicer.

Signed-off-by: Kurt Van Dijck <redacted>

Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

Hello Marc,

i really appreciate your work regarding the CAN driver maintenance together
with Wolfgang!

Would it probably make sense to add your name to the drivers/net/can section
in the MAINTAINERS file so that Dave and the other listeners on netdev-ML can
appraise your Acked-by more easily?

Regards,
Oliver

Re: [PATCH] CAN: add controller hardware name for Softing cards

From: David Miller <davem@davemloft.net>
Date: 2011-02-28 20:08:24

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Mon, 21 Feb 2011 10:13:37 +0100

On 02/21/2011 10:04 AM, Kurt Van Dijck wrote:

quoted

I just found that the controller hardware name is not set for the Softing
driver. After this patch, "$ ip -d link show" looks nicer.

Signed-off-by: Kurt Van Dijck <redacted>

Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

Applied, thanks.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help