[PATCH resend] Bluetooth: l2cap: fix misuse of logical operation in place of bitop

Subsystems: bluetooth subsystem, the rest

STALE5758d

2 messages, 2 authors, 2011-01-14 · open the first message on its own page

[PATCH resend] Bluetooth: l2cap: fix misuse of logical operation in place of bitop

From: David Sterba <hidden>
Date: 2011-01-14 14:00:05

CC: Marcel Holtmann <marcel@holtmann.org>
CC: "Gustavo F. Padovan" <redacted>
CC: João Paulo Rechi Vita <redacted>
Signed-off-by: David Sterba <redacted>
---

Andrew, this has not been picked up by maintainers since 27.12., please consider it for -mm.

 net/bluetooth/l2cap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
index cd8f6ea..bdfdfdc 100644
--- a/net/bluetooth/l2cap.c
+++ b/net/bluetooth/l2cap.c
@@ -1893,8 +1893,8 @@ static int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, struct ms
 		if (pi->mode == L2CAP_MODE_STREAMING) {
 			l2cap_streaming_send(sk);
 		} else {
-			if (pi->conn_state & L2CAP_CONN_REMOTE_BUSY &&
-					pi->conn_state && L2CAP_CONN_WAIT_F) {
+			if ((pi->conn_state & L2CAP_CONN_REMOTE_BUSY) &&
+					(pi->conn_state & L2CAP_CONN_WAIT_F)) {
 				err = len;
 				break;
 			}
-- 
1.7.3.4.626.g73e7b

Re: [PATCH resend] Bluetooth: l2cap: fix misuse of logical operation in place of bitop

From: Gustavo F. Padovan <hidden>
Date: 2011-01-14 16:30:29

Hi all,

* David Sterba [off-list ref] [2011-01-14 14:59:44 +0100]:
CC: Marcel Holtmann <redacted>
CC: "Gustavo F. Padovan" <redacted>
CC: João Paulo Rechi Vita <redacted>
Signed-off-by: David Sterba <redacted>
---

Andrew, this has not been picked up by maintainers since 27.12., please consider it for -mm.

 net/bluetooth/l2cap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
I'm taking care of this. Sorry for the delay, I've been away a bit.
Patch is now applied to Bluetooth tree. Thanks.

-- 
Gustavo F. Padovan
http://profusion.mobi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help