[PATCH] vxge: Remember to release firmware after upgrading firmware

Subsystems: networking drivers, the rest

STALE5752d

3 messages, 3 authors, 2011-01-14 · open the first message on its own page

[PATCH] vxge: Remember to release firmware after upgrading firmware

From: Jesper Juhl <hidden>
Date: 2011-01-13 20:25:28

Regardless of whether the firmware update being performed by 
vxge_fw_upgrade() is a success or not we must still remember to always 
release_firmware() before returning.

Signed-off-by: Jesper Juhl <redacted>
---
 vxge-main.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
index 1ac9b56..c81a651 100644
--- a/drivers/net/vxge/vxge-main.c
+++ b/drivers/net/vxge/vxge-main.c
@@ -4120,6 +4120,7 @@ int vxge_fw_upgrade(struct vxgedev *vdev, char *fw_name, int override)
 	       "hotplug event.\n");
 
 out:
+	release_firmware(fw);
 	return ret;
 }
 

-- 
Jesper Juhl <jj@chaosbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

RE: [PATCH] vxge: Remember to release firmware after upgrading firmware {nodisc}

From: Ramkrishna Vepa <hidden>
Date: 2011-01-13 20:40:40

quoted hunk
Regardless of whether the firmware update being performed by
vxge_fw_upgrade() is a success or not we must still remember to always
release_firmware() before returning.

Signed-off-by: Jesper Juhl <redacted>
---
 vxge-main.c |    1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/vxge/vxge-main.c b/drivers/net/vxge/vxge-main.c
index 1ac9b56..c81a651 100644
--- a/drivers/net/vxge/vxge-main.c
+++ b/drivers/net/vxge/vxge-main.c
@@ -4120,6 +4120,7 @@ int vxge_fw_upgrade(struct vxgedev *vdev, char
*fw_name, int override)
 	       "hotplug event.\n");

 out:
+	release_firmware(fw);
 	return ret;
 }
Thanks!

Acked-by: Ram Vepa <redacted>

Re: [PATCH] vxge: Remember to release firmware after upgrading firmware

From: David Miller <davem@davemloft.net>
Date: 2011-01-14 05:50:09

From: Jesper Juhl <redacted>
Date: Thu, 13 Jan 2011 21:25:20 +0100 (CET)
Regardless of whether the firmware update being performed by 
vxge_fw_upgrade() is a success or not we must still remember to always 
release_firmware() before returning.

Signed-off-by: Jesper Juhl <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help