[PATCH] ksz884x: Fix section mismatch derived from pci_device_driver variable

Subsystems: networking drivers, the rest

STALE5767d

3 messages, 2 authors, 2011-01-03 · open the first message on its own page

[PATCH] ksz884x: Fix section mismatch derived from pci_device_driver variable

From: Sedat Dilek <hidden>
Date: 2011-01-03 02:02:05

WARNING: drivers/net/ksz884x.o(.data+0x18): Section mismatch in reference from the variable pci_device_driver to the function .init.text:pcidev_init()
The variable pci_device_driver references
the function __init pcidev_init()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,

This patch fixes the warning.

Tested with linux-next (next-20101231)

Signed-off-by: Sedat Dilek <redacted>
---
 drivers/net/ksz884x.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ksz884x.c b/drivers/net/ksz884x.c
index 49ea870..515b0d7 100644
--- a/drivers/net/ksz884x.c
+++ b/drivers/net/ksz884x.c
@@ -7277,7 +7277,7 @@ static struct pci_device_id pcidev_table[] = {
 
 MODULE_DEVICE_TABLE(pci, pcidev_table);
 
-static struct pci_driver pci_device_driver = {
+static struct pci_driver pci_device_driver __refdata = {
 #ifdef CONFIG_PM
 	.suspend	= pcidev_suspend,
 	.resume		= pcidev_resume,
-- 
1.7.4.rc0

Re: [PATCH] ksz884x: Fix section mismatch derived from pci_device_driver variable

From: David Miller <davem@davemloft.net>
Date: 2011-01-03 19:52:20

From: Sedat Dilek <redacted>
Date: Mon,  3 Jan 2011 03:01:44 +0100
WARNING: drivers/net/ksz884x.o(.data+0x18): Section mismatch in reference from the variable pci_device_driver to the function .init.text:pcidev_init()
The variable pci_device_driver references
the function __init pcidev_init()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,

This patch fixes the warning.

Tested with linux-next (next-20101231)

Signed-off-by: Sedat Dilek <redacted>
pcidev_init() should be marked __devinit instead of __init to fix this
bug.

Re: [PATCH] ksz884x: Fix section mismatch derived from pci_device_driver variable

From: Sedat Dilek <hidden>
Date: 2011-01-03 21:07:51

On Mon, Jan 3, 2011 at 8:52 PM, David Miller [off-list ref] wrote:
From: Sedat Dilek <redacted>
Date: Mon,  3 Jan 2011 03:01:44 +0100
quoted
WARNING: drivers/net/ksz884x.o(.data+0x18): Section mismatch in reference from the variable pci_device_driver to the function .init.text:pcidev_init()
The variable pci_device_driver references
the function __init pcidev_init()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,

This patch fixes the warning.

Tested with linux-next (next-20101231)

Signed-off-by: Sedat Dilek <redacted>
pcidev_init() should be marked __devinit instead of __init to fix this
bug.
I have sent a new fixed version.

- Sedat -
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help