[PATCH net-2.6] bnx2: Always set ETH_FLAG_TXVLAN

Subsystems: networking drivers, the rest

STALE5741d

2 messages, 2 authors, 2011-01-25 · open the first message on its own page

[PATCH net-2.6] bnx2: Always set ETH_FLAG_TXVLAN

From: "Michael Chan" <mchan@broadcom.com>
Date: 2011-01-24 23:53:15

TSO does not work if the VLAN tag is in the packet (non-accelerated).
We may be able to remove this restriction in future firmware.

Reported-by: Eric Dumazet <redacted>
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
 drivers/net/bnx2.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index df99edf..99e7652 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -7553,6 +7553,10 @@ bnx2_set_flags(struct net_device *dev, u32 data)
 	    !(data & ETH_FLAG_RXVLAN))
 		return -EINVAL;
 
+	/* TSO with VLAN tag won't work with current firmware */
+	if (!(data & ETH_FLAG_TXVLAN))
+		return -EINVAL;
+
 	rc = ethtool_op_set_flags(dev, data, ETH_FLAG_RXHASH | ETH_FLAG_RXVLAN |
 				  ETH_FLAG_TXVLAN);
 	if (rc)
-- 
1.6.4.GIT

Re: [PATCH net-2.6] bnx2: Always set ETH_FLAG_TXVLAN

From: David Miller <davem@davemloft.net>
Date: 2011-01-25 07:15:57

From: "Michael Chan" <mchan@broadcom.com>
Date: Mon, 24 Jan 2011 14:59:02 -0800
TSO does not work if the VLAN tag is in the packet (non-accelerated).
We may be able to remove this restriction in future firmware.

Reported-by: Eric Dumazet <redacted>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help