[PATCH] typhoon: Kill references to UTS_RELEASE

Subsystems: networking drivers, the rest

STALE5743d

3 messages, 2 authors, 2011-01-25 · open the first message on its own page

[PATCH] typhoon: Kill references to UTS_RELEASE

From: David Miller <davem@davemloft.net>
Date: 2011-01-24 23:11:41

This makes the driver get rebuilt every single time you
type 'make' which is beyond rediculious.

I hereby declare this driver to have version "1.0"

Signed-off-by: David S. Miller <davem@davemloft.net>
---

This has been driving me nuts for a long time.

 drivers/net/typhoon.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c
index a3c46f6..7fa5ec2 100644
--- a/drivers/net/typhoon.c
+++ b/drivers/net/typhoon.c
@@ -123,12 +123,11 @@ static const int multicast_filter_limit = 32;
 #include <linux/in6.h>
 #include <linux/dma-mapping.h>
 #include <linux/firmware.h>
-#include <generated/utsrelease.h>
 
 #include "typhoon.h"
 
 MODULE_AUTHOR("David Dillow <dave@thedillows.org>");
-MODULE_VERSION(UTS_RELEASE);
+MODULE_VERSION("1.0");
 MODULE_LICENSE("GPL");
 MODULE_FIRMWARE(FIRMWARE_NAME);
 MODULE_DESCRIPTION("3Com Typhoon Family (3C990, 3CR990, and variants)");
-- 
1.7.3.4

Re: [PATCH] typhoon: Kill references to UTS_RELEASE

From: David Dillow <dave@thedillows.org>
Date: 2011-01-25 20:00:12

On Mon, 2011-01-24 at 15:12 -0800, David Miller wrote:
This makes the driver get rebuilt every single time you
type 'make' which is beyond rediculious.
Indeed, that's stupid.
I hereby declare this driver to have version "1.0"
Wish you'd gone to 1.6 or 2.0 since the last version before Joe's/my
changes was 1.5.9, but it's pretty irrelevant anyways. Hmm, does
anything complain if we just remove the MODULE_VERSION?

Re: [PATCH] typhoon: Kill references to UTS_RELEASE

From: David Miller <davem@davemloft.net>
Date: 2011-01-25 20:32:29

From: David Dillow <dave@thedillows.org>
Date: Tue, 25 Jan 2011 14:39:25 -0500
On Mon, 2011-01-24 at 15:12 -0800, David Miller wrote:
quoted
I hereby declare this driver to have version "1.0"
Wish you'd gone to 1.6 or 2.0 since the last version before Joe's/my
changes was 1.5.9, but it's pretty irrelevant anyways. Hmm, does
anything complain if we just remove the MODULE_VERSION?
I don't think anything does, but it's presence helps distribution
vendors so they can add their own sub-version suffix to the driver
version when they make local changes.

And you really do want that when users report problems but are using
vendor kernels, it makes the fact that local changes exist from the
vendor easy to see.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help