[PATCH 1/1] IPVS netns BUG, register sysctl for root ns

Subsystems: ipvs, netfilter, networking [general], the rest

STALE5739d

2 messages, 2 authors, 2011-01-25 · open the first message on its own page

[PATCH 1/1] IPVS netns BUG, register sysctl for root ns

From: Hans Schillstrom <hidden>
Date: 2011-01-24 14:14:41

The newly created table was not used when register sysctl for a new namespace.
I.e. sysctl doesn't work for other than root namespace (init_net)

Signed-off-by: Hans Schillstrom <redacted>
---
 net/netfilter/ipvs/ip_vs_ctl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
index 68b8033..98df59a 100644
--- a/net/netfilter/ipvs/ip_vs_ctl.c
+++ b/net/netfilter/ipvs/ip_vs_ctl.c
@@ -3556,7 +3556,7 @@ int __net_init __ip_vs_control_init(struct net *net)
 
 
 	ipvs->sysctl_hdr = register_net_sysctl_table(net, net_vs_ctl_path,
-						  vs_vars);
+						     tbl);
 	if (ipvs->sysctl_hdr == NULL)
 		goto err_reg;
 	ip_vs_new_estimator(net, ipvs->tot_stats);
-- 
1.7.2.3

Re: [PATCH 1/1] IPVS netns BUG, register sysctl for root ns

From: Simon Horman <horms@verge.net.au>
Date: 2011-01-25 02:15:17

On Mon, Jan 24, 2011 at 03:14:41PM +0100, Hans Schillstrom wrote:
The newly created table was not used when register sysctl for a new namespace.
I.e. sysctl doesn't work for other than root namespace (init_net)

Signed-off-by: Hans Schillstrom <redacted>
Thanks Hans.

Patrick, please pull this change from

git://git.kernel.org/pub/scm/linux/kernel/git/horms/lvs-test-2.6.git for-patrick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help