Question on code in __netif_receive_skb
From: Ben Greear <hidden>
Date: 2010-10-25 21:37:08
From: Ben Greear <hidden>
Date: 2010-10-25 21:37:08
While poking at the VLAN crash, I noticed this code in dev.c, in the __netif_receive_skb method. if (vlan_tx_tag_present(skb) && vlan_hwaccel_do_receive(skb)) return NET_RX_SUCCESS; As far as I can tell, this return can never happen because vlan_hwaccel_do_receive always returns 0. Maybe it should instead check for return-value == 0 and return success in that case? Thanks, Ben -- Ben Greear [off-list ref] Candela Technologies Inc http://www.candelatech.com