[PATCH 1/3 v2] net: fail alloc_netdev_mq if queue count < 1

Subsystems: networking [general], the rest

STALE5781d

2 messages, 2 authors, 2010-10-19 · open the first message on its own page

[PATCH 1/3 v2] net: fail alloc_netdev_mq if queue count < 1

From: Tom Herbert <hidden>
Date: 2010-10-19 03:56:07

In alloc_netdev_mq fail if requested queue_count < 1.

Signed-off-by: Tom Herbert <redacted>
---
 net/core/dev.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 04972a4..f44d29a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5511,6 +5511,12 @@ struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name,
 
 	BUG_ON(strlen(name) >= sizeof(dev->name));
 
+	if (queue_count < 1) {
+		pr_err("alloc_netdev: Unable to allocate device "
+		       "with zero queues.\n");
+		return NULL;
+	}
+
 	alloc_size = sizeof(struct net_device);
 	if (sizeof_priv) {
 		/* ensure 32-byte alignment of private area */
-- 
1.7.1

Re: [PATCH 1/3 v2] net: fail alloc_netdev_mq if queue count < 1

From: Eric Dumazet <hidden>
Date: 2010-10-19 05:02:39

Le lundi 18 octobre 2010 à 20:55 -0700, Tom Herbert a écrit :
In alloc_netdev_mq fail if requested queue_count < 1.

Signed-off-by: Tom Herbert <redacted>
---
 net/core/dev.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
Acked-by: Eric Dumazet <redacted>

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help