[PATCH net-next] arp: remove unnecessary export of arp_broken_ops

STALE5793d

2 messages, 2 authors, 2010-09-30 · open the first message on its own page

[PATCH net-next] arp: remove unnecessary export of arp_broken_ops

From: Stephen Hemminger <hidden>
Date: 2010-09-29 03:08:11

arp_broken_ops is only used in arp.c

Signed-off-by: Stephen Hemminger <redacted>

--- a/include/net/arp.h	2010-09-29 10:36:46.125871462 +0900
+++ b/include/net/arp.h	2010-09-29 10:36:51.195923872 +0900
@@ -26,6 +26,4 @@ extern struct sk_buff *arp_create(int ty
 				  const unsigned char *target_hw);
 extern void arp_xmit(struct sk_buff *skb);
 
-extern const struct neigh_ops arp_broken_ops;
-
 #endif	/* _ARP_H */
--- a/net/ipv4/arp.c	2010-09-29 10:36:46.135874409 +0900
+++ b/net/ipv4/arp.c	2010-09-29 10:37:15.985915408 +0900
@@ -161,7 +161,7 @@ static const struct neigh_ops arp_direct
 	.queue_xmit =		dev_queue_xmit,
 };
 
-const struct neigh_ops arp_broken_ops = {
+static const struct neigh_ops arp_broken_ops = {
 	.family =		AF_INET,
 	.solicit =		arp_solicit,
 	.error_report =		arp_error_report,
@@ -170,7 +170,6 @@ const struct neigh_ops arp_broken_ops = 
 	.hh_output =		dev_queue_xmit,
 	.queue_xmit =		dev_queue_xmit,
 };
-EXPORT_SYMBOL(arp_broken_ops);
 
 struct neigh_table arp_tbl = {
 	.family		= AF_INET,

Re: [PATCH net-next] arp: remove unnecessary export of arp_broken_ops

From: David Miller <davem@davemloft.net>
Date: 2010-09-30 02:46:31

From: Stephen Hemminger <redacted>
Date: Wed, 29 Sep 2010 12:08:02 +0900
arp_broken_ops is only used in arp.c

Signed-off-by: Stephen Hemminger <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help