[PATCH 17/42] drivers/net/irda: Adjust confusing if indentation

Subsystems: networking drivers, the rest

STALE5831d

2 messages, 2 authors, 2010-08-17 · open the first message on its own page

[PATCH 17/42] drivers/net/irda: Adjust confusing if indentation

From: Julia Lawall <hidden>
Date: 2010-08-05 20:22:10

From: Julia Lawall <redacted>

Indent the branch of an if.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@

(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

if (p1[0].column == p2[0].column):
  cocci.print_main("branch",p1)
  cocci.print_secs("after",p2)
// </smpl>

Signed-off-by: Julia Lawall <redacted>

---
 drivers/net/irda/mcs7780.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/irda/mcs7780.c b/drivers/net/irda/mcs7780.c
index 5b1036a..74b20f1 100644
--- a/drivers/net/irda/mcs7780.c
+++ b/drivers/net/irda/mcs7780.c
@@ -734,7 +734,7 @@ static int mcs_net_open(struct net_device *netdev)
 	}
 
 	if (!mcs_setup_urbs(mcs))
-	goto error3;
+		goto error3;
 
 	ret = mcs_receive_start(mcs);
 	if (ret)

Re: [PATCH 17/42] drivers/net/irda: Adjust confusing if indentation

From: David Miller <davem@davemloft.net>
Date: 2010-08-17 08:51:33

Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help