RTL8180 : improper usage of dma_addr_t

From: August <hidden>
Date: 2010-07-19 08:23:59

linux-kernel-version : 2.6.34
drivers/net/wireless/rtl818x/rtl8180_dev.c
__LINE__ :  500
cpu_to_le32((u32)dma + ((i + 1) % entries) * sizeof(*ring));

Although in the x86 infrastruct, the value of dma_addr == line addr,
it is inproper usage here.

suggestion:
cpu_to_le32((u32)(&priv[0]) + ((i + 1) % entries) * sizeof(*ring));
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help