On Mon, 2010-06-21 at 13:31 -0700, Peter P Waskiewicz Jr wrote:

On Mon, 21 Jun 2010, Ben Hutchings wrote:

quoted

On Wed, 2010-02-03 at 23:51 -0800, Jeff Kirsher wrote:

quoted

From: Peter Waskiewicz <redacted>

Program underlying ethernet devices with n-tuple flow classification
filters.

This also adds a new flag to ethtool_flags, allowing n-tuple
programming to be toggled using the set_flags call.

I just noticed a problem with the implementation which makes me wonder
whether this was tested at all:

Yes, it was tested.  We didn't hit every corner case, which I think your 
catch below is a corner case issue.  Our hardware can only do so much.

It's not a corner case.  You have added options that cannot work
correctly.

[...]

When this was proposed, we added the IPv4 address as a single int.  People 
seemed ok with it at the time, so we went with it.  If you have a 
different approach, please present it.

And you don't think it matters that the address has to be written
differently on big- and little-endian architectures?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.