Call trace related to bonding seen in 2.6.34

From: <hidden>
Date: 2010-06-01 17:55:44

Hello,

Call trace related to bond_mii_monitor  as described in this thread -
http://patchwork.ozlabs.org/patch/41288/ was seen on 2.6.34 kernel.
(Trace is similar to what is described in the post dated 2009-12-17
21:31:36.) The trace is seen when the network service is stopped. The
issue occurs when the network service is started and stopped in quick
succession. 

Bonding device configuration parameters are as below -

Bonding driver version:3.6.0
Mode: balance-alb (issue is also seen with active-backup mode)
Miimon=100
3 slaves with link up and one slave with link down.

Though this requires more thought and investigation, I thought this
could be a good data point. The below change to the bonding driver
seemed to make the issue go away -

drivers/net/bonding/bond_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c
b/drivers/net/bonding/bond_main.c
index 0075514..f280aaf 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -2408,7 +2408,7 @@ void bond_mii_monitor(struct work_struct *work)
        }

 re_arm:
-       if (bond->params.miimon)
+       if (bond->params.miimon && !bond->kill_timers)
                queue_delayed_work(bond->wq, &bond->mii_work,
 
msecs_to_jiffies(bond->params.miimon));
 out:




Any thoughts ?


With regards,
Narendra K

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help