[PATCH 14/20] drivers/net/vmxnet3: Use kzalloc

-----Original Message-----
From: pv-drivers-bounces@vmware.com [mailto:pv-drivers-
bounces@vmware.com] On Behalf Of Julia Lawall
Sent: Thursday, May 13, 2010 1:06 PM
To: Shreyas Bhatewara; VMware, Inc.; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org; kernel-janitors@vger.kernel.org
Subject: [Pv-drivers] [PATCH 14/20] drivers/net/vmxnet3: Use kzalloc

From: Julia Lawall <redacted>

Use kzalloc rather than the combination of kmalloc and memset.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,size,flags;
statement S;
@@

-x = kmalloc(size,flags);
+x = kzalloc(size,flags);
 if (x == NULL) S
-memset(x, 0, size);
// </smpl>

Signed-off-by: Julia Lawall <redacted>

---
 drivers/net/vmxnet3/vmxnet3_drv.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff -u -p a/drivers/net/vmxnet3/vmxnet3_drv.c
b/drivers/net/vmxnet3/vmxnet3_drv.c

--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c

@@ -1369,13 +1369,12 @@ vmxnet3_rq_create(struct vmxnet3_rx_queu

 	sz = sizeof(struct vmxnet3_rx_buf_info) * (rq->rx_ring[0].size +
 						   rq->rx_ring[1].size);
-	bi = kmalloc(sz, GFP_KERNEL);
+	bi = kzalloc(sz, GFP_KERNEL);
 	if (!bi) {
 		printk(KERN_ERR "%s: failed to allocate rx bufinfo\n",
 		       adapter->netdev->name);
 		goto err;
 	}
-	memset(bi, 0, sz);
 	rq->buf_info[0] = bi;
 	rq->buf_info[1] = bi + rq->rx_ring[0].size;

_______________________________________________
Pv-drivers mailing list
Pv-drivers@vmware.com
http://mailman2.vmware.com/mailman/listinfo/pv-drivers