Thread (5 messages) 5 messages, 2 authors, 2010-05-06

Re: tip: origin tree boot crash (in the new micrel phy driver)

From: Ingo Molnar <hidden>
Date: 2010-05-06 10:44:51
Also in: lkml

* David Miller [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: David Miller <davem@davemloft.net>
Date: Thu, 06 May 2010 03:10:40 -0700 (PDT)
quoted
From: Ingo Molnar <redacted>
Date: Thu, 6 May 2010 11:59:40 +0200
quoted
I bisected it back to the following commit:

d05070091849015f8c5b7d55cd75b86ebb61b3ec is the first bad commit
commit d05070091849015f8c5b7d55cd75b86ebb61b3ec
Author: David J. Choi [off-list ref]
Date:   Thu Apr 29 06:12:41 2010 +0000

    drivers/net/phy: micrel phy driver
 ...
quoted
quoted
Disabling the driver fixes the crash.
David please fix this crash, thanks.
Nevermind, Ingo please test this fix:
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 0cd80e4..e67691d 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -32,6 +32,7 @@ static int kszphy_config_init(struct phy_device *phydev)
 
 static struct phy_driver ks8001_driver = {
 	.phy_id		= PHY_ID_KS8001,
+	.name		= "Micrel KS8001",
 	.phy_id_mask	= 0x00fffff0,
 	.features	= PHY_BASIC_FEATURES,
 	.flags		= PHY_POLL,
This fixes the crash, thanks Dave!

Tested-by: Ingo Molnar <redacted>

	Ingo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help