[PATCH] benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c

Subsystems: networking drivers, the rest

STALE6025d

3 messages, 3 authors, 2010-03-27 · open the first message on its own page

[PATCH] benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c

From: <hidden>
Date: 2010-03-26 06:13:08

Fix the following warnings:

be_ethtool.c:493: warning: integer constant is too large for 'long' type
be_ethtool.c:493: warning: integer constant is too large for 'long' type

Signed-off-by: Zhitong Wang <redacted>

---
 drivers/net/benet/be_ethtool.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/benet/be_ethtool.c b/drivers/net/benet/be_ethtool.c
index 9560d48..51e1065 100644
--- a/drivers/net/benet/be_ethtool.c
+++ b/drivers/net/benet/be_ethtool.c
@@ -490,7 +490,7 @@ be_test_ddr_dma(struct be_adapter *adapter)
 {
 	int ret, i;
 	struct be_dma_mem ddrdma_cmd;
-	u64 pattern[2] = {0x5a5a5a5a5a5a5a5a, 0xa5a5a5a5a5a5a5a5};
+	u64 pattern[2] = {0x5a5a5a5a5a5a5a5aULL, 0xa5a5a5a5a5a5a5a5ULL};
 
 	ddrdma_cmd.size = sizeof(struct be_cmd_req_ddrdma_test);
 	ddrdma_cmd.va = pci_alloc_consistent(adapter->pdev, ddrdma_cmd.size,
-- 
1.6.5.3

Re: [PATCH] benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c

From: Ajit Khaparde <hidden>
Date: 2010-03-26 17:16:28

On 26/03/10 14:12 +0800, wzt.wzt@gmail.com wrote:
Fix the following warnings:

be_ethtool.c:493: warning: integer constant is too large for 'long' type
be_ethtool.c:493: warning: integer constant is too large for 'long' type

Signed-off-by: Zhitong Wang <redacted>
I would suggest using be2net instead of benet during the commit. 
be2net: Fix compile warnnings in drivers/net/benet/be_ethtool.c

Acked-by: Ajit Khaparde <redacted>

Re: [PATCH] benet: Fix compile warnnings in drivers/net/benet/be_ethtool.c

From: David Miller <davem@davemloft.net>
Date: 2010-03-27 15:31:57

From: Ajit Khaparde <redacted>
Date: Fri, 26 Mar 2010 22:46:18 +0530
On 26/03/10 14:12 +0800, wzt.wzt@gmail.com wrote:
quoted
Fix the following warnings:

be_ethtool.c:493: warning: integer constant is too large for 'long' type
be_ethtool.c:493: warning: integer constant is too large for 'long' type

Signed-off-by: Zhitong Wang <redacted>
I would suggest using be2net instead of benet during the commit. 
be2net: Fix compile warnnings in drivers/net/benet/be_ethtool.c

Acked-by: Ajit Khaparde <redacted>
Well, you cannot be surprised that people will use "benet"
since that is the name of the directory the driver lives
under.  It is not even referred to as "be2net" in the
MAINTAINERS entry.

I'm applying this fix as-is.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help