Re: [PATCH v2 4/7] drivers/net/wireless: Use STD_IW_HANDLER macro | netdev | Ratatoskr

[PATCH v2 0/7] wireless: Use macros from wireless.h · Joe Perches <joe@perches.com> · 2010-03-18
[PATCH v2 2/7] net/wireless/wext_core.c: Use IW_IOCTL_IDX macro · Joe Perches <joe@perches.com> · 2010-03-18
[PATCH v2 4/7] drivers/net/wireless: Use STD_IW_HANDLER macro · Joe Perches <joe@perches.com> · 2010-03-18
Re: [PATCH v2 4/7] drivers/net/wireless: Use STD_IW_HANDLER macro · Pavel Roskin <hidden> · 2010-03-18
[PATCH v2 6/7] orinoco/wext.c: Remove local #define STD_IW_HANDLER · Joe Perches <joe@perches.com> · 2010-03-18
[PATCH v2 5/7] drivers/net: Remove local #define IW_IOCTL, use STD_IW_HANDLER · Joe Perches <joe@perches.com> · 2010-03-18
Re: [PATCH v2 5/7] drivers/net: Remove local #define IW_IOCTL, use STD_IW_HANDLER · Geoff Levand <hidden> · 2010-03-31
[PATCH v2 3/7] net/wireless/wext-core.c: Use IW_EVENT_IDX macro · Joe Perches <joe@perches.com> · 2010-03-18
Re: [PATCH v2 0/7] wireless: Use macros from wireless.h · Johannes Berg <johannes@sipsolutions.net> · 2010-03-18

Re: [PATCH v2 4/7] drivers/net/wireless: Use STD_IW_HANDLER macro

From: Pavel Roskin <hidden>
Date: 2010-03-18 17:25:29
Also in: linux-wireless, lkml

On Wed, 2010-03-17 at 23:21 -0700, Joe Perches wrote:

Convert direct uses of [ (foo - SIOCIWFIRST) , fn)

Signed-off-by: Joe Perches <joe@perches.com>

...

 static const iw_handler	wl3501_handler[] = {
-	[SIOCGIWNAME	- SIOCIWFIRST] = wl3501_get_name,

...

+	STD_IW_HANDLER(SIOCGIWNAME, wl3501_get_name),

You are introducing an unnecessary cast here.  That's bad.

-- 
Regards,
Pavel Roskin