Thread (28 messages) 28 messages, 8 authors, 2010-02-18

Re: [PATCH RFC] r8169: straighten out overlength frame detection (v3)

From: Brandon Philips <hidden>
Date: 2010-02-18 19:37:47

On 16:50 Sat 30 Jan 2010, Neil Horman wrote:
On Tue, Jan 12, 2010 at 01:16:46AM +0100, Francois Romieu wrote:
quoted
On Sun, Jan 10, 2010 at 10:45:04PM -0800, David Miller wrote:
[...]
quoted
In my opinion if you reset, you give them more power.

Instead of just dropping the next few frames, you allow them
to cause a drop of how ever many RX frames can arrive during
the reset period _PLUS_ the amount of other RX frames which
were in the receive ring at the point of detection.
Sure.

The fragmented frame test has been moved a few lines up, before checking
for the status bits. Exceedingly small frames are detected and dropped
as well.

I have spent the evening disrupting the communication. As a challenger
one does not even need complete control : send a few random packets and
the card goes to neverland. :o/

I'll do some tests limiting the crap at the first packet.
Any further results you can share with us Francois?
Can I offer any help? I found that I have access to a Rev 0x10 card.

Cheers,

	Brandon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help