[RESEND PATCH 3/3] X25: Fix oops and refcnt problems from x25_dev_get
From: andrew hendry <hidden>
Date: 2009-12-14 22:03:43
Also in:
lkml
Calls to x25_dev_get check for dev = NULL which was not set. It allowed x25 to set routes and ioctls on down interfaces. This caused oopses and refcnt problems on device_unregister. Signed-off-by: Andrew Hendry <redacted>
--- a/net/x25/x25_route.c 2009-11-25 09:30:52.003038597 +1100
+++ b/net/x25/x25_route.c 2009-11-25 09:33:37.627093701 +1100@@ -136,8 +136,10 @@ struct net_device *x25_dev_get(char *dev #if defined(CONFIG_LLC) || defined(CONFIG_LLC_MODULE) && dev->type != ARPHRD_ETHER #endif - ))) + ))) { dev_put(dev); + dev = NULL; + } return dev; }