Thread (2 messages) 2 messages, 2 authors, 2009-11-30

Re: Problem with tcp (2.6.31) as first

From: David Miller <davem@davemloft.net>
Date: 2009-11-30 20:56:18

From: Eric Dumazet <redacted>
Date: Mon, 30 Nov 2009 10:12:19 +0100
[PATCH] tcp: tcp_disconnect() should clear window_clamp

NFS can reuse its TCP socket after calling tcp_disconnect().
We noticed window scaling was not negotiated in SYN packet of next connection request.

Fix is to clear tp->window_clamp in tcp_disconnect().

Reported-by: Krzysztof Oledzki <redacted>
Tested-by: Krzysztof Oledzki <redacted>
Signed-off-by: Eric Dumazet <redacted>
Applied, thanks Eric.

You voiced some concerns about window clamp route and socket settings
and whatnot.  But I think the route side should be OK.  When a new
connect() occurs, TCP will reinitialize the window clamp setting based
upon the route metric and other values.

The TCP_WINDOW_CLAMP socket option case is tedious however.  If we
want to preserve such settings across disconnect operations we'll need
to store two pieces of state I believe.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help