question about drivers/atm/firestream.c

In the file drivers/atm/firestream.c in the function fs_open, there is the 
following code:

       if (vci != ATM_VPI_UNSPEC && vpi != ATM_VCI_UNSPEC)
                set_bit(ATM_VF_ADDR, &atm_vcc->flags);

Should ATM_VPI_UNSPEC and ATM_VCI_UNSPEC be exchanged?  They have the same 
value, but the code looks a bit odd this way nonetheless.

thanks,
julia

In message [off-list ref],Julia Lawall writes:

In the file drivers/atm/firestream.c in the function fs_open, there is the 
following code:

      if (vci != ATM_VPI_UNSPEC && vpi != ATM_VCI_UNSPEC)
               set_bit(ATM_VF_ADDR, &atm_vcc->flags);

Should ATM_VPI_UNSPEC and ATM_VCI_UNSPEC be exchanged?  They have the same 
value, but the code looks a bit odd this way nonetheless.

yes this is backwards.  this whole UNSPEC business should really go away.
drivers should never need to worry about getting an unspecified vpi or
vci.  this should be chosen by the next layer up in the stack.