[PATCH]netxen: fix checking

Subsystems: networking drivers, the rest

STALE6295d

2 messages, 2 authors, 2009-06-11 · open the first message on its own page

[PATCH]netxen: fix checking

From: Figo.zhang <hidden>
Date: 2009-06-10 14:13:49

vfree() does its own 'NULL' check, so no need for check before
calling it.

Signed-off-by: Figo.zhang <redacted>
---   
 drivers/net/netxen/netxen_nic_init.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/netxen/netxen_nic_init.c b/drivers/net/netxen/netxen_nic_init.c
index 0759c35..7ab0aa4 100644
--- a/drivers/net/netxen/netxen_nic_init.c
+++ b/drivers/net/netxen/netxen_nic_init.c
@@ -208,14 +208,11 @@ void netxen_free_sw_resources(struct netxen_adapter *adapter)
 	recv_ctx = &adapter->recv_ctx;
 	for (ring = 0; ring < adapter->max_rds_rings; ring++) {
 		rds_ring = &recv_ctx->rds_rings[ring];
-		if (rds_ring->rx_buf_arr) {
-			vfree(rds_ring->rx_buf_arr);
-			rds_ring->rx_buf_arr = NULL;
-		}
+		vfree(rds_ring->rx_buf_arr);
+		rds_ring->rx_buf_arr = NULL;
 	}
 
-	if (adapter->cmd_buf_arr)
-		vfree(adapter->cmd_buf_arr);
+	vfree(adapter->cmd_buf_arr);
 	return;
 }
 

Re: [PATCH]netxen: fix checking

From: David Miller <davem@davemloft.net>
Date: 2009-06-11 09:51:08

From: "Figo.zhang" <redacted>
Date: Wed, 10 Jun 2009 22:13:47 +0800
vfree() does its own 'NULL' check, so no need for check before
calling it.

Signed-off-by: Figo.zhang <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help