[patch] net/ps3: Fix wireless AP connect error handling

STALE6347d

3 messages, 2 authors, 2009-04-24 · open the first message on its own page

[patch] net/ps3: Fix wireless AP connect error handling

From: Geoff Levand <hidden>
Date: 2009-03-30 18:20:42

From: Masakazu Mokuno <redacted>

This patch fixes the bug that the driver tries to continue to
connect(associate) to AP even if gelic_wl_do_{wpa,wep}_setup() fails,

Signed-off-by: Masakazu Mokuno <redacted>
Signed-off-by: Geoff Levand <redacted>
---
 drivers/net/ps3_gelic_wireless.c |    3 +++
 1 file changed, 3 insertions(+)
--- a/drivers/net/ps3_gelic_wireless.c
+++ b/drivers/net/ps3_gelic_wireless.c
@@ -2101,6 +2101,9 @@ static int gelic_wl_associate_bss(struct
 	if (ret) {
 		pr_debug("%s: WEP/WPA setup failed %d\n", __func__,
 			 ret);
+		ret = -EPERM;
+		gelic_wl_send_iwap_event(wl, NULL);
+		goto out;
 	}
 
 	/* start association */


[patch] net/ps3: Fix wireless AP connect error handling

From: Geoff Levand <hidden>
Date: 2009-04-23 22:46:25

From: Masakazu Mokuno <redacted>

This patch fixes the bug that the driver tries to continue to
connect(associate) to AP even if gelic_wl_do_{wpa,wep}_setup() fails,

Signed-off-by: Masakazu Mokuno <redacted>
Signed-off-by: Geoff Levand <redacted>
---
Hi John,

I didn't see this get merged in to 2.6.30 yet.  Could you let me know the status?

-Geoff

 drivers/net/ps3_gelic_wireless.c |    3 +++
 1 file changed, 3 insertions(+)
--- a/drivers/net/ps3_gelic_wireless.c
+++ b/drivers/net/ps3_gelic_wireless.c
@@ -2101,6 +2101,9 @@ static int gelic_wl_associate_bss(struct
 	if (ret) {
 		pr_debug("%s: WEP/WPA setup failed %d\n", __func__,
 			 ret);
+		ret = -EPERM;
+		gelic_wl_send_iwap_event(wl, NULL);
+		goto out;
 	}
 
 	/* start association */



Re: [patch] net/ps3: Fix wireless AP connect error handling

From: John W. Linville <hidden>
Date: 2009-04-24 20:15:54

On Thu, Apr 23, 2009 at 03:46:17PM -0700, Geoff Levand wrote:
From: Masakazu Mokuno <redacted>

This patch fixes the bug that the driver tries to continue to
connect(associate) to AP even if gelic_wl_do_{wpa,wep}_setup() fails,

Signed-off-by: Masakazu Mokuno <redacted>
Signed-off-by: Geoff Levand <redacted>
---
Hi John,

I didn't see this get merged in to 2.6.30 yet.  Could you let me know the status?

-Geoff
I have it queued for 2.6.31.  Does it cause a crash or other problem
serious enough to merit pushing it for 2.6.30?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help