[PATCH 01/18] bnx2x: Remove redundant smb_mb on unload
From: Eilon Greenstein <hidden>
Date: 2009-03-02 18:00:04
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Subject: [PATCH 01/18] bnx2x: Remove redundant smb_mb on unload As noted by Ben Hutchings [off-list ref], these smb_mb are not needed Signed-off-by: Eilon Greenstein <redacted> --- drivers/net/bnx2x_main.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index 9427175..5954bed 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c@@ -7210,7 +7210,6 @@ static int bnx2x_nic_unload(struct bnx2x *bp, int unload_mode) struct bnx2x_fastpath *fp = &bp->fp[i]; cnt = 1000; - smp_mb(); while (bnx2x_has_tx_work_unload(fp)) { bnx2x_tx_int(fp, 1000);
@@ -7226,7 +7225,6 @@ static int bnx2x_nic_unload(struct bnx2x *bp, int unload_mode) } cnt--; msleep(1); - smp_mb(); } } /* Give HW time to discard old tx messages */
--
1.5.4.3