Re: why usr/include/linux/if_frad.h is required

Jaswinder Singh Rajput [off-list ref] writes:

usr/include/linux/if_frad.h is covered with CONFIG_DLCI from many years
and no body is complaining about it so it means no body is using it.

So should we need to drop #if / #endif pair or the whole file from
userspace.

I think the file. "Empty file exported to userspace", long unused. We
can also have it back there, and it being not exported is an indicator
that it's not used. I guess the #ifdef __KERNEL__ can be removed, too.
-- 
Krzysztof Halasa

On Wed, Jan 21, 2009 at 6:36 AM, Krzysztof Halasa [off-list ref] wrote:

Jaswinder Singh Rajput [off-list ref] writes:

quoted

usr/include/linux/if_frad.h is covered with CONFIG_DLCI from many years
and no body is complaining about it so it means no body is using it.

So should we need to drop #if / #endif pair or the whole file from
userspace.

I think the file. "Empty file exported to userspace", long unused. We
can also have it back there, and it being not exported is an indicator
that it's not used. I guess the #ifdef __KERNEL__ can be removed, too.

I will definately define #ifdef __KERNEL__ but I am also curious after
defining it there is no point of making empty
usr/include/linux/if_frad.h

--
JSR

On Wed, Jan 21, 2009 at 10:20:17AM +0530, Jaswinder Singh Rajput wrote:

On Wed, Jan 21, 2009 at 6:36 AM, Krzysztof Halasa [off-list ref] wrote:

quoted

Jaswinder Singh Rajput [off-list ref] writes:

quoted

usr/include/linux/if_frad.h is covered with CONFIG_DLCI from many years
and no body is complaining about it so it means no body is using it.

So should we need to drop #if / #endif pair or the whole file from
userspace.

I think the file. "Empty file exported to userspace", long unused. We
can also have it back there, and it being not exported is an indicator
that it's not used. I guess the #ifdef __KERNEL__ can be removed, too.

I will definately define #ifdef __KERNEL__ but I am also curious after
defining it there is no point of making empty
usr/include/linux/if_frad.h

Googling a bit did not turn up _any_ non-kernel hits that has relevance.
So based on the information given in this thread I strongly
suggest to drop the export of this header.

	Sam

From: Sam Ravnborg <redacted>
Date: Wed, 21 Jan 2009 06:33:10 +0100

On Wed, Jan 21, 2009 at 10:20:17AM +0530, Jaswinder Singh Rajput wrote:

quoted

On Wed, Jan 21, 2009 at 6:36 AM, Krzysztof Halasa [off-list ref] wrote:

quoted

Jaswinder Singh Rajput [off-list ref] writes:

quoted

usr/include/linux/if_frad.h is covered with CONFIG_DLCI from many years
and no body is complaining about it so it means no body is using it.

So should we need to drop #if / #endif pair or the whole file from
userspace.

I think the file. "Empty file exported to userspace", long unused. We
can also have it back there, and it being not exported is an indicator
that it's not used. I guess the #ifdef __KERNEL__ can be removed, too.

I will definately define #ifdef __KERNEL__ but I am also curious after
defining it there is no point of making empty
usr/include/linux/if_frad.h

Googling a bit did not turn up _any_ non-kernel hits that has relevance.
So based on the information given in this thread I strongly
suggest to drop the export of this header.

Sure, but on the other hand this makes all of the userland APIs
essentially inaccessible and undefined.

I bet Sangoma's internal tools reference this stuff.

On Tue, 20 Jan 2009 22:15:04 -0800 (PST)
David Miller [off-list ref] wrote:

From: Sam Ravnborg <redacted>
Date: Wed, 21 Jan 2009 06:33:10 +0100

quoted

On Wed, Jan 21, 2009 at 10:20:17AM +0530, Jaswinder Singh Rajput wrote:

quoted

On Wed, Jan 21, 2009 at 6:36 AM, Krzysztof Halasa [off-list ref] wrote:

quoted

Jaswinder Singh Rajput [off-list ref] writes:

quoted

usr/include/linux/if_frad.h is covered with CONFIG_DLCI from many years
and no body is complaining about it so it means no body is using it.

So should we need to drop #if / #endif pair or the whole file from
userspace.

I think the file. "Empty file exported to userspace", long unused. We
can also have it back there, and it being not exported is an indicator
that it's not used. I guess the #ifdef __KERNEL__ can be removed, too.

I will definately define #ifdef __KERNEL__ but I am also curious after
defining it there is no point of making empty
usr/include/linux/if_frad.h

Googling a bit did not turn up _any_ non-kernel hits that has relevance.
So based on the information given in this thread I strongly
suggest to drop the export of this header.

Sure, but on the other hand this makes all of the userland APIs
essentially inaccessible and undefined.

I bet Sangoma's internal tools reference this stuff.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

There are no references if_frad.h in the version of Sangoma (out of tree) code
that we use in Vyatta. 

From: Stephen Hemminger <redacted>
Date: Wed, 21 Jan 2009 17:38:38 +1100

There are no references if_frad.h in the version of Sangoma (out of
tree) code that we use in Vyatta.

frad-0.20:src/dlcicfg.c

It includes linux/if_frad.h and also performs the DLCI_SET_CONF
ioctl.

Enough evidence to show we need to keep this header in the
export set.  Let's just kill the bogus CONFIG_* ifdef
tests in there.

On Wed, Jan 21, 2009 at 03:37:12PM -0800, David Miller wrote:

From: Stephen Hemminger <redacted>
Date: Wed, 21 Jan 2009 17:38:38 +1100

quoted

There are no references if_frad.h in the version of Sangoma (out of
tree) code that we use in Vyatta.

frad-0.20:src/dlcicfg.c

It includes linux/if_frad.h and also performs the DLCI_SET_CONF
ioctl.

Enough evidence to show we need to keep this header in the
export set.  Let's just kill the bogus CONFIG_* ifdef
tests in there.

Thanks for investigating David.

	Sam

On Wed, 2009-01-21 at 15:37 -0800, David Miller wrote:

From: Stephen Hemminger <redacted>
Date: Wed, 21 Jan 2009 17:38:38 +1100

quoted

There are no references if_frad.h in the version of Sangoma (out of
tree) code that we use in Vyatta.

frad-0.20:src/dlcicfg.c

It includes linux/if_frad.h and also performs the DLCI_SET_CONF
ioctl.

Enough evidence to show we need to keep this header in the
export set.  Let's just kill the bogus CONFIG_* ifdef
tests in there.

After killing CONFIG_DLCI and CONFIG_DLCI_MODULE, it is also killing the
kernel:

  CC      net/socket.o
In file included from net/socket.c:75:
include/linux/if_frad.h:170: error: ‘CONFIG_DLCI_MAX’ undeclared here (not in a function)
make[1]: *** [net/socket.o] Error 1
make: *** [net] Error 2

because these things still depends on CONFIG_DLCI:

struct frad_local
{
   struct net_device_stats stats;

   /* devices which this FRAD is slaved to */
   struct net_device     *master[CONFIG_DLCI_MAX];
   short             dlci[CONFIG_DLCI_MAX];

Are you still sure we do not need CONFIG_DLCI.

--
JSR