Re: 2.6.28-git8: tg3 doesn't work due to firmware not loading (-git7 is ok)

Hello alessandro,

On Wed, Jan 7, 2009 at 7:54 PM, Alessandro Suardi
[off-list ref] wrote:

Note that I don't have CONFIG_FIRMWARE_IN_KERNEL, but on
 the other hand I didn't earlier, either... and yes, CONFIG_MODULES=y.

Please try with CONFIG_FIRMWARE_IN_KERNEL , is this makes some difference.

--
JSR

On Thu, Jan 8, 2009 at 7:12 AM, Jaswinder Singh Rajput
[off-list ref] wrote:

Hello alessandro,

On Wed, Jan 7, 2009 at 7:54 PM, Alessandro Suardi
[off-list ref] wrote:

quoted

Note that I don't have CONFIG_FIRMWARE_IN_KERNEL, but on
 the other hand I didn't earlier, either... and yes, CONFIG_MODULES=y.

Please try with CONFIG_FIRMWARE_IN_KERNEL , is this makes some difference.

Yes it does, thank you - 2.6.28-git11 with CONFIG_FIRMWARE_IN_KERNEL
 gets my tg3 back to work on boot. Must be a requirement since -git8 then ?

Thanks again, ciao,

--alessandro

 "Sun keeps rising in the west / I keep on waking fully confused"

   (The Replacements, "Within Your Reach")

From: "Alessandro Suardi" <redacted>
Date: Thu, 8 Jan 2009 21:33:35 +0100

On Thu, Jan 8, 2009 at 7:12 AM, Jaswinder Singh Rajput
[off-list ref] wrote:

quoted

Hello alessandro,

On Wed, Jan 7, 2009 at 7:54 PM, Alessandro Suardi
[off-list ref] wrote:

quoted

Note that I don't have CONFIG_FIRMWARE_IN_KERNEL, but on
 the other hand I didn't earlier, either... and yes, CONFIG_MODULES=y.

Please try with CONFIG_FIRMWARE_IN_KERNEL , is this makes some difference.

Yes it does, thank you - 2.6.28-git11 with CONFIG_FIRMWARE_IN_KERNEL
 gets my tg3 back to work on boot. Must be a requirement since -git8 then ?

It is if you don't have the tg3 firmware files in your filesystem
already.

On Thu, Jan 8, 2009 at 9:53 PM, David Miller [off-list ref] wrote:

From: "Alessandro Suardi" <redacted>
Date: Thu, 8 Jan 2009 21:33:35 +0100

quoted

On Thu, Jan 8, 2009 at 7:12 AM, Jaswinder Singh Rajput
[off-list ref] wrote:

quoted

Hello alessandro,

On Wed, Jan 7, 2009 at 7:54 PM, Alessandro Suardi
[off-list ref] wrote:

quoted

Note that I don't have CONFIG_FIRMWARE_IN_KERNEL, but on
 the other hand I didn't earlier, either... and yes, CONFIG_MODULES=y.

Please try with CONFIG_FIRMWARE_IN_KERNEL , is this makes some difference.

Yes it does, thank you - 2.6.28-git11 with CONFIG_FIRMWARE_IN_KERNEL
 gets my tg3 back to work on boot. Must be a requirement since -git8 then ?

It is if you don't have the tg3 firmware files in your filesystem
already.

As I mentioned in the original email to LKML about -git8, and in
 the first CC to netdev about -git10, I appear to have these files
 in /lib/firmware/tigon. I save every single .config file I used in the
 last, what, four years ?

.config-2.6.28-git10:# CONFIG_FIRMWARE_IN_KERNEL is not set
.config-2.6.28-git11:CONFIG_FIRMWARE_IN_KERNEL=y
.config-2.6.28-git2:# CONFIG_FIRMWARE_IN_KERNEL is not set
.config-2.6.28-git3:# CONFIG_FIRMWARE_IN_KERNEL is not set
.config-2.6.28-git4:# CONFIG_FIRMWARE_IN_KERNEL is not set
.config-2.6.28-git5:# CONFIG_FIRMWARE_IN_KERNEL is not set
.config-2.6.28-git6:# CONFIG_FIRMWARE_IN_KERNEL is not set
.config-2.6.28-git7:# CONFIG_FIRMWARE_IN_KERNEL is not set
.config-2.6.28-git8:# CONFIG_FIRMWARE_IN_KERNEL is not set

-git-2 through -git-7 work
-git8 and -git10 don't work
-git11 works

Clearly the requirement changed in -git8, AFAICS.

thanks,

--alessandro

 "Sun keeps rising in the west / I keep on waking fully confused"

   (The Replacements, "Within Your Reach")

From: "Alessandro Suardi" <redacted>
Date: Fri, 9 Jan 2009 18:30:40 +0100

Clearly the requirement changed in -git8, AFAICS.

Because -git8 is where the firmware requirement got added.

If you build the TG3 driver statically into your kernel,
the only way to get the firmware properly loaded is to
enable that CONFIG_FIRMWARE_IN_KERNEL option.

Your filesystem isn't mounted when the driver initializes
in that case, therefore there is no way to get at the
firwware that might be present there.

On Fri, Jan 9, 2009 at 11:04 PM, David Miller [off-list ref] wrote:

From: "Alessandro Suardi" <redacted>
Date: Fri, 9 Jan 2009 18:30:40 +0100

quoted

Clearly the requirement changed in -git8, AFAICS.

Because -git8 is where the firmware requirement got added.

OK, thanks.

If you build the TG3 driver statically into your kernel,
the only way to get the firmware properly loaded is to
enable that CONFIG_FIRMWARE_IN_KERNEL option.

Your filesystem isn't mounted when the driver initializes
in that case, therefore there is no way to get at the
firwware that might be present there.

And indeed I do build tg3 in-kernel. But since the config
 option was present previously, perhaps it would have
 been the case to change the help text for tg3 explaining
 that now a non-modular build requires an extra step ?

Or maybe kbuild allows to select FIRMWARE_IN_KERNEL
 if tg3 is built non-modular ?

My only observation is that a make oldconfig shouldn't
 change a working setup to a non-working one (though
 it already happened once to me in a couple of weeks,
 the other being I915 DRM being silently skipped as a
 consequence of becoming dependent on CONFIG_FB)
 with a new kernel patch.

Clearly, if there is no easy way to avoid such a situation,
 it's okay - LKML and the other Linux-related lists are
 always helpful.

Thanks again, ciao,

--alessandro

 "Sun keeps rising in the west / I keep on waking fully confused"

   (The Replacements, "Within Your Reach")