Thread (9 messages) 9 messages, 2 authors, 2008-12-09

Re: sumgem problems with initializiation order at a 1000SX SERDES card [experimental patch]

From: David Miller <davem@davemloft.net>
Date: 2008-12-09 08:06:30

From: Hermann Lauer <redacted>
Date: Mon, 8 Dec 2008 16:59:36 +0100
On Thu, Dec 04, 2008 at 05:33:24PM -0800, David Miller wrote:
quoted
And this new code is just a copy of the PHY init sequence on
PCS, so we should split that out into a helper function instead
of duplicating it.

Any time gem_reset() is invoked, the PCS is going to need to be
reset like this, so let's do the advertisement reinit there.

Does this version of the fix work for you?
Yes, works the same. It has some delay before receiving packets works
after an ifconfig up or a reestablishing of the link, but thats
the same as with the experimental patch.
Probably the link state handling has to be improved, I'm not
shure my experimental patch was correct there.

But as the driver is working now with this patch on this hardware
and not without - please commit.
I agree, and that's what I'll do.

Thanks for testing.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help