Re: phylib: Wake PHY state machine on interrupt

From: David Miller <davem@davemloft.net>
Date: 2008-10-08 22:48:07
Subsystem: ethernet phy library, networking drivers, the rest · Maintainers: Andrew Lunn, Heiner Kallweit, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

With a minor coding style fix, I've applied your patch
as below.  Thanks.

commit 0acb28396728f42b6b1553c85d27c37513796043
Author: Trent Piepho [off-list ref]
Date:   Wed Oct 8 15:46:57 2008 -0700

    phylib: Wake PHY state machine on interrupt
    
    This way the phy layer will respond to a change in phy state immediately,
    instead of up to one second later when the state machine timer runs.
    
    Signed-off-by: Trent Piepho [off-list ref]
    Acked-by: Andy Fleming [off-list ref]
    Signed-off-by: David S. Miller [off-list ref]
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 0433fcd..20cc82c 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -729,6 +729,12 @@ static void phy_change(struct work_struct *work)
 	if (err)
 		goto irq_enable_err;
 
+	/* Stop timer and run the state queue now.  The work function for
+	 * state_queue will start the timer up again.
+	 */
+	del_timer(&phydev->phy_timer);
+	schedule_work(&phydev->state_queue);
+
 	return;
 
 irq_enable_err:
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help