Re: linux-next: Tree for September 13 (3c509)

5 messages, 4 authors, 2008-09-15 · open the first message on its own page

Re: linux-next: Tree for September 13 (3c509)

From: Randy Dunlap <hidden>
Date: 2008-09-14 21:18:23

drivers/net/3c509.c fails (CONFIG_PM=y) with:

drivers/built-in.o:(.data+0x7dcc): undefined reference to `el3_resume'
drivers/built-in.o:(.data+0x7e08): undefined reference to `el3_resume'

It seems that this function does not exist in the source file.

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

Re: linux-next: Tree for September 13 (3c509)

From: Adrian Bunk <bunk@kernel.org>
Date: 2008-09-15 14:12:20

On Sun, Sep 14, 2008 at 02:17:57PM -0700, Randy Dunlap wrote:
drivers/net/3c509.c fails (CONFIG_PM=y) with:

drivers/built-in.o:(.data+0x7dcc): undefined reference to `el3_resume'
drivers/built-in.o:(.data+0x7e08): undefined reference to `el3_resume'

It seems that this function does not exist in the source file.

It got removed by:


commit 107aeb9753159da848f066b26557f0aaab900a90
Author: Hannes Reinecke [off-list ref]
Date:   Wed Sep 10 14:16:04 2008 +0200

    Driver core: Use dev_get_drvdata() accessors
    
    Deprecated direct access to the ->driver_data field and
    use accessors throughout.
    
    Signed-off-by: Hannes Reinecke [off-list ref]
    Cc: Kay Sievers [off-list ref]
    Signed-off-by: Greg Kroah-Hartman [off-list ref]


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: linux-next: Tree for September 13 (3c509)

From: Hannes Reinecke <hare@suse.de>
Date: 2008-09-15 14:27:39

Hi Adrian,

Adrian Bunk wrote:
On Sun, Sep 14, 2008 at 02:17:57PM -0700, Randy Dunlap wrote:
quoted
drivers/net/3c509.c fails (CONFIG_PM=y) with:

drivers/built-in.o:(.data+0x7dcc): undefined reference to `el3_resume'
drivers/built-in.o:(.data+0x7e08): undefined reference to `el3_resume'

It seems that this function does not exist in the source file.

It got removed by:


commit 107aeb9753159da848f066b26557f0aaab900a90
Author: Hannes Reinecke [off-list ref]
Date:   Wed Sep 10 14:16:04 2008 +0200

    Driver core: Use dev_get_drvdata() accessors
    
    Deprecated direct access to the ->driver_data field and
    use accessors throughout.
    
    Signed-off-by: Hannes Reinecke [off-list ref]
    Cc: Kay Sievers [off-list ref]
    Signed-off-by: Greg Kroah-Hartman [off-list ref]
Sorry. Here it is again.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)

Re: linux-next: Tree for September 13 (3c509)

From: Randy Dunlap <hidden>
Date: 2008-09-15 15:04:35

On Mon, 15 Sep 2008 16:27:24 +0200 Hannes Reinecke wrote:
Hi Adrian,

Adrian Bunk wrote:
quoted
On Sun, Sep 14, 2008 at 02:17:57PM -0700, Randy Dunlap wrote:
quoted
drivers/net/3c509.c fails (CONFIG_PM=y) with:

drivers/built-in.o:(.data+0x7dcc): undefined reference to `el3_resume'
drivers/built-in.o:(.data+0x7e08): undefined reference to `el3_resume'

It seems that this function does not exist in the source file.

It got removed by:


commit 107aeb9753159da848f066b26557f0aaab900a90
Author: Hannes Reinecke [off-list ref]
Date:   Wed Sep 10 14:16:04 2008 +0200

    Driver core: Use dev_get_drvdata() accessors
    
    Deprecated direct access to the ->driver_data field and
    use accessors throughout.
    
    Signed-off-by: Hannes Reinecke [off-list ref]
    Cc: Kay Sievers [off-list ref]
    Signed-off-by: Greg Kroah-Hartman [off-list ref]
Sorry. Here it is again.
Ack, that [attached] patch fixes the build.

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

Re: linux-next: Tree for September 13 (3c509)

From: Greg KH <gregkh@suse.de>
Date: 2008-09-15 19:01:41

On Mon, Sep 15, 2008 at 08:03:57AM -0700, Randy Dunlap wrote:
On Mon, 15 Sep 2008 16:27:24 +0200 Hannes Reinecke wrote:
quoted
Hi Adrian,

Adrian Bunk wrote:
quoted
On Sun, Sep 14, 2008 at 02:17:57PM -0700, Randy Dunlap wrote:
quoted
drivers/net/3c509.c fails (CONFIG_PM=y) with:

drivers/built-in.o:(.data+0x7dcc): undefined reference to `el3_resume'
drivers/built-in.o:(.data+0x7e08): undefined reference to `el3_resume'

It seems that this function does not exist in the source file.

It got removed by:


commit 107aeb9753159da848f066b26557f0aaab900a90
Author: Hannes Reinecke [off-list ref]
Date:   Wed Sep 10 14:16:04 2008 +0200

    Driver core: Use dev_get_drvdata() accessors
    
    Deprecated direct access to the ->driver_data field and
    use accessors throughout.
    
    Signed-off-by: Hannes Reinecke [off-list ref]
    Cc: Kay Sievers [off-list ref]
    Signed-off-by: Greg Kroah-Hartman [off-list ref]
Sorry. Here it is again.
Ack, that [attached] patch fixes the build.
Now merged in with Hannes's original patch.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help