[PATCH -next] net namespace: build when SYSCTL=n
From: Randy Dunlap <hidden>
Date: 2008-07-19 00:18:48
3 messages, 3 authors, 2008-07-19 · open the first message on its own page
From: Randy Dunlap <hidden>
Date: 2008-07-19 00:18:48
From: Randy Dunlap <redacted> When CONFIG_SYSCTL=n, build fails with: linux-next-20080718/include/net/net_namespace.h:40: error: field 'sysctls' has incomplete type Signed-off-by: Randy Dunlap <redacted> --- include/net/net_namespace.h | 2 ++ 1 file changed, 2 insertions(+)
--- linux-next-20080718.orig/include/net/net_namespace.h
+++ linux-next-20080718/include/net/net_namespace.h@@ -37,7 +37,9 @@ struct net { struct proc_dir_entry *proc_net; struct proc_dir_entry *proc_net_stat; +#ifdef CONFIG_SYSCTL struct ctl_table_set sysctls; +#endif struct net_device *loopback_dev; /* The loopback */
--- ~Randy Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA http://linuxplumbersconf.org/
From: David Miller <davem@davemloft.net>
Date: 2008-07-19 01:01:20
From: Randy Dunlap <redacted> Date: Fri, 18 Jul 2008 17:18:12 -0700
From: Randy Dunlap <redacted> When CONFIG_SYSCTL=n, build fails with: linux-next-20080718/include/net/net_namespace.h:40: error: field 'sysctls' has incomplete type Signed-off-by: Randy Dunlap <redacted>
This 'sysctls' member isn't present in my networking tree, it must be coming from some other tree and thus the patch needs to be applied there.
From: Al Viro <viro@ZenIV.linux.org.uk>
Date: 2008-07-19 02:34:10
On Fri, Jul 18, 2008 at 06:01:07PM -0700, David Miller wrote:
From: Randy Dunlap <redacted> Date: Fri, 18 Jul 2008 17:18:12 -0700quoted
From: Randy Dunlap <redacted> When CONFIG_SYSCTL=n, build fails with: linux-next-20080718/include/net/net_namespace.h:40: error: field 'sysctls' has incomplete type Signed-off-by: Randy Dunlap <redacted>This 'sysctls' member isn't present in my networking tree, it must be coming from some other tree and thus the patch needs to be applied there.
Yup. Applied.