Re: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver

 > Output of checkpatch (scripts/checkpatch.pl in kernel source).
 > Personally, I am not a whitespace bigot, and don't think
 > all the warnings in checkpatch have to be fixed.
 > 
 > ----------
 > ERROR: patch seems to be corrupt (line wrapped?)
 > #121: FILE: drivers/net/atl1e/atl1e.h:9:
 > ree
 > 
 > WARNING: space prohibited between function name and open parenthesis '('
 > #212: FILE: drivers/net/atl1e/atl1e.h:97:
 > +       _tpd =3D (((_vlan) << (4)) | (((_vlan) >> 13) & 7) |\

It's kind of pointless to run checkpatch on a corrupted patch (the email
was quoted-printable and you didn't decode it back to text).  Of course
it's also better to send non-mangled patches.

 - R.

On Thursday, July 17, 2008 12:36 AM
Roland Dreier [off-list ref] wrote:

 > Output of checkpatch (scripts/checkpatch.pl in kernel source).
 > Personally, I am not a whitespace bigot, and don't think

quoted

all the warnings in checkpatch have to be fixed.

 >
 > ----------
 > ERROR: patch seems to be corrupt (line wrapped?)  > #121:
FILE: drivers/net/atl1e/atl1e.h:9:
 > ree
 >
 > WARNING: space prohibited between function name and open
parenthesis '('
 > #212: FILE: drivers/net/atl1e/atl1e.h:97:
 > +       _tpd =3D (((_vlan) << (4)) | (((_vlan) >> 13) & 7) |\

It's kind of pointless to run checkpatch on a corrupted patch
(the email was quoted-printable and you didn't decode it back
to text).  Of course it's also better to send non-mangled patches.

 - R.

Hi, Roland
        I used outlook to send these patches, can you give me some
aderise on how to send non-mangled patches.

Best wishes
jie

Jie Yang wrote:

On Thursday, July 17, 2008 12:36 AM
Roland Dreier [off-list ref] wrote:
  

quoted

 > Output of checkpatch (scripts/checkpatch.pl in kernel source).
 > Personally, I am not a whitespace bigot, and don't think
    

quoted

all the warnings in checkpatch have to be fixed.
      

Hi, Roland
        I used outlook to send these patches, can you give me some
aderise on how to send non-mangled patches.
  

You should use Thunderbird to send you patchs. And check it by send the mail to yourself.

Regards.
Wei Yongjun

On Thu, 17 Jul 2008 11:30:27 +0800
Wei Yongjun [off-list ref] wrote:

Jie Yang wrote:

quoted

On Thursday, July 17, 2008 12:36 AM
Roland Dreier [off-list ref] wrote:
  

quoted

 > Output of checkpatch (scripts/checkpatch.pl in kernel source).
 > Personally, I am not a whitespace bigot, and don't think
    

quoted

all the warnings in checkpatch have to be fixed.
      

Hi, Roland
        I used outlook to send these patches, can you give me some
aderise on how to send non-mangled patches.
  

You should use Thunderbird to send you patchs. And check it by send the 
mail to yourself.

Regards.
Wei Yongjun

Alternatively, use a text file as attachment. It doesn't work as well but then
it comes through unmangled.