Re: [PATCH net-2.6 2/2] ipv6: minor cleanup in net/ipv6/tcp_ipv6.c (RESEND).

Hi,

In net/ipv6/tcp_ipv6.c:

1) Remove unneeded tcp_v6_send_check() declaration.

2) Unify two consecutive #ifdef CONFIG_TCP_MD5SIG (with nothing in
  between them) into one #ifdef CONFIG_TCP_MD5SIG.


Regards,
Rami Rosen


Signed-off-by: Rami Rosen <redacted>
On Tue, Jun 17, 2008 at 3:08 AM, David Miller [off-list ref] wrote:

From: "Rami Rosen" <redacted>
Date: Mon, 16 Jun 2008 12:09:31 +0300

quoted

2) Unify two consecutive #ifdef CONFIG_TCP_MD5SIG (with nothing in
   between them) into one #ifdef CONFIG_TCP_MD5SIG.

I think there should be an empty line between local variable
declarations and actual code in a function.  Please fix this
up, thanks.

From: "Rami Rosen" <redacted>
Date: Tue, 17 Jun 2008 09:22:53 +0300

In net/ipv6/tcp_ipv6.c:

1) Remove unneeded tcp_v6_send_check() declaration.

2) Unify two consecutive #ifdef CONFIG_TCP_MD5SIG (with nothing in
  between them) into one #ifdef CONFIG_TCP_MD5SIG.

Signed-off-by: Rami Rosen <redacted>

Rami, I was going to apply this to net-next-2.6

The MD5 code changed a bit and in fact that
sequence of local variables then code with ifdef
protection isn't even there any more.

Could you respin this patch against net-next-2.6,
just the #1 part?

Thanks!