[PATCH v2] fs_enet: Fix a memory leak in fs_enet_mdio_probe

Subsystems: networking drivers, the rest

STALE6696d

2 messages, 2 authors, 2008-05-06 · open the first message on its own page

[PATCH v2] fs_enet: Fix a memory leak in fs_enet_mdio_probe

From: Scott Wood <hidden>
Date: 2008-05-02 18:42:27

There are more memory leaks in the !PPC_CPM_NEW_BINDING case, but that code
will disappear soon along with arch/ppc.

Reported by Daniel Marjamki [off-list ref] at
http://bugzilla.kernel.org/show_bug.cgi?id=10591

Signed-off-by: Scott Wood <redacted>
---
 drivers/net/fs_enet/mii-fec.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/fs_enet/mii-fec.c b/drivers/net/fs_enet/mii-fec.c
index ba75efc..f0014cf 100644
--- a/drivers/net/fs_enet/mii-fec.c
+++ b/drivers/net/fs_enet/mii-fec.c
@@ -194,7 +194,7 @@ static int __devinit fs_enet_mdio_probe(struct of_device *ofdev,
 
 	ret = of_address_to_resource(ofdev->node, 0, &res);
 	if (ret)
-		return ret;
+		goto out_res;
 
 	snprintf(new_bus->id, MII_BUS_ID_SIZE, "%x", res.start);
 
@@ -236,6 +236,7 @@ out_free_irqs:
 	kfree(new_bus->irq);
 out_unmap_regs:
 	iounmap(fec->fecp);
+out_res:
 out_fec:
 	kfree(fec);
 out_mii:
-- 
1.5.4.4

Re: [PATCH v2] fs_enet: Fix a memory leak in fs_enet_mdio_probe

From: Jeff Garzik <hidden>
Date: 2008-05-06 16:23:21

Scott Wood wrote:
There are more memory leaks in the !PPC_CPM_NEW_BINDING case, but that code
will disappear soon along with arch/ppc.

Reported by Daniel Marjamki [off-list ref] at
http://bugzilla.kernel.org/show_bug.cgi?id=10591

Signed-off-by: Scott Wood <redacted>
---
 drivers/net/fs_enet/mii-fec.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
applied

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help