[PATCH 3/7] net/ipv6/ndisc.c: remove unused variable

STALE6762d

2 messages, 2 authors, 2008-03-23 · open the first message on its own page

[PATCH 3/7] net/ipv6/ndisc.c: remove unused variable

From: Julia Lawall <hidden>
Date: 2008-03-15 16:03:52

From: Julia Lawall <redacted>

The variable hlen is initialized but never used otherwise.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
identifier i;
constant C;
@@

(
extern T i;
|
- T i;
  <+... when != i
- i = C;
  ...+>
)
// </smpl>

Signed-off-by: Julia Lawall <redacted>
---
 net/ipv6/ndisc.c |    2 --
 1 file changed, 2 deletions(-)

diff -u -p a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
--- a/net/ipv6/ndisc.c 2008-03-12 14:13:15.000000000 +0100
+++ b/net/ipv6/ndisc.c 2008-03-15 07:30:11.000000000 +0100
@@ -1420,7 +1420,6 @@ void ndisc_send_redirect(struct sk_buff 
 	u8 *opt;
 	int rd_len;
 	int err;
-	int hlen;
 	u8 ha_buf[MAX_ADDR_LEN], *ha = NULL;
 
 	dev = skb->dev;
@@ -1491,7 +1490,6 @@ void ndisc_send_redirect(struct sk_buff 
 		return;
 	}
 
-	hlen = 0;
 
 	skb_reserve(buff, LL_RESERVED_SPACE(dev));
 	ip6_nd_hdr(sk, buff, dev, &saddr_buf, &ipv6_hdr(skb)->saddr,

Re: [PATCH 3/7] net/ipv6/ndisc.c: remove unused variable

From: David Miller <davem@davemloft.net>
Date: 2008-03-23 01:04:25

From: Julia Lawall <redacted>
Date: Sat, 15 Mar 2008 17:03:20 +0100 (CET)
The variable hlen is initialized but never used otherwise.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
 ...
Signed-off-by: Julia Lawall <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help