[PATCH 12/15] [IPV4]: Use proc_create() to setup ->proc_fops first

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE6729d

2 messages, 2 authors, 2008-02-28 · open the first message on its own page

[PATCH 12/15] [IPV4]: Use proc_create() to setup ->proc_fops first

From: Wang Chen <hidden>
Date: 2008-02-28 11:00:35

Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.

Signed-off-by: Wang Chen <redacted>
---
 net/ipv4/route.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 525787b..7b5e8e1 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -542,12 +542,11 @@ static __init int ip_rt_proc_init(struct net *net)
 	if (!pde)
 		goto err1;
 
-	pde = create_proc_entry("rt_cache", S_IRUGO, net->proc_net_stat);
+	pde = proc_create("rt_cache", S_IRUGO,
+			  net->proc_net_stat, &rt_cpu_seq_fops);
 	if (!pde)
 		goto err2;
 
-	pde->proc_fops = &rt_cpu_seq_fops;
-
 #ifdef CONFIG_NET_CLS_ROUTE
 	pde = create_proc_read_entry("rt_acct", 0, net->proc_net,
 			ip_rt_acct_read, NULL);
-- 
WCN

Re: [PATCH 12/15] [IPV4]: Use proc_create() to setup ->proc_fops first

From: David Miller <davem@davemloft.net>
Date: 2008-02-28 22:14:32

From: Wang Chen <redacted>
Date: Thu, 28 Feb 2008 18:58:06 +0800
Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.

Signed-off-by: Wang Chen <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help