[PATCH 08/15] [NEIGHBOUR]: Use proc_create() to setup ->proc_fops first

Subsystems: networking [general], the rest

STALE6729d

2 messages, 2 authors, 2008-02-28 · open the first message on its own page

[PATCH 08/15] [NEIGHBOUR]: Use proc_create() to setup ->proc_fops first

From: Wang Chen <hidden>
Date: 2008-02-28 10:59:36

Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.

Signed-off-by: Wang Chen <redacted>
---
 net/core/neighbour.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 2328acb..aef0153 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1389,10 +1389,10 @@ void neigh_table_init_no_netlink(struct neigh_table *tbl)
 		panic("cannot create neighbour cache statistics");
 
 #ifdef CONFIG_PROC_FS
-	tbl->pde = create_proc_entry(tbl->id, 0, init_net.proc_net_stat);
+	tbl->pde = proc_create(tbl->id, 0, init_net.proc_net_stat,
+			       &neigh_stat_seq_fops);
 	if (!tbl->pde)
 		panic("cannot create neighbour proc dir entry");
-	tbl->pde->proc_fops = &neigh_stat_seq_fops;
 	tbl->pde->data = tbl;
 #endif
 
-- 
WCN

Re: [PATCH 08/15] [NEIGHBOUR]: Use proc_create() to setup ->proc_fops first

From: David Miller <davem@davemloft.net>
Date: 2008-02-28 22:10:59

From: Wang Chen <redacted>
Date: Thu, 28 Feb 2008 18:57:07 +0800
Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.

Signed-off-by: Wang Chen <redacted>
APplied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help