[PATCH 07/15] [LLC]: Use proc_create() to setup ->proc_fops first

Subsystems: llc (802.2), networking [general], the rest

STALE6729d

2 messages, 2 authors, 2008-02-28 · open the first message on its own page

[PATCH 07/15] [LLC]: Use proc_create() to setup ->proc_fops first

From: Wang Chen <hidden>
Date: 2008-02-28 10:59:23

Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.

Signed-off-by: Wang Chen <redacted>
---
 net/llc/llc_proc.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/net/llc/llc_proc.c b/net/llc/llc_proc.c
index cb34bc0..48212c0 100644
--- a/net/llc/llc_proc.c
+++ b/net/llc/llc_proc.c
@@ -239,18 +239,14 @@ int __init llc_proc_init(void)
 		goto out;
 	llc_proc_dir->owner = THIS_MODULE;
 
-	p = create_proc_entry("socket", S_IRUGO, llc_proc_dir);
+	p = proc_create("socket", S_IRUGO, llc_proc_dir, &llc_seq_socket_fops);
 	if (!p)
 		goto out_socket;
 
-	p->proc_fops = &llc_seq_socket_fops;
-
-	p = create_proc_entry("core", S_IRUGO, llc_proc_dir);
+	p = proc_create("core", S_IRUGO, llc_proc_dir, &llc_seq_core_fops);
 	if (!p)
 		goto out_core;
 
-	p->proc_fops = &llc_seq_core_fops;
-
 	rc = 0;
 out:
 	return rc;
-- 
WCN

Re: [PATCH 07/15] [LLC]: Use proc_create() to setup ->proc_fops first

From: David Miller <davem@davemloft.net>
Date: 2008-02-28 22:09:01

From: Wang Chen <redacted>
Date: Thu, 28 Feb 2008 18:56:54 +0800
Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.

Signed-off-by: Wang Chen <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help