[PATCH 05/15] [IPX]: Use proc_create() to setup ->proc_fops first

Subsystems: networking [general], the rest

STALE6729d

2 messages, 2 authors, 2008-02-28 · open the first message on its own page

[PATCH 05/15] [IPX]: Use proc_create() to setup ->proc_fops first

From: Wang Chen <hidden>
Date: 2008-02-28 10:58:52

Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.

Signed-off-by: Wang Chen <redacted>
---
 net/ipx/ipx_proc.c |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/net/ipx/ipx_proc.c b/net/ipx/ipx_proc.c
index d483a00..5ed97ad 100644
--- a/net/ipx/ipx_proc.c
+++ b/net/ipx/ipx_proc.c
@@ -358,22 +358,19 @@ int __init ipx_proc_init(void)
 
 	if (!ipx_proc_dir)
 		goto out;
-	p = create_proc_entry("interface", S_IRUGO, ipx_proc_dir);
+	p = proc_create("interface", S_IRUGO,
+			ipx_proc_dir, &ipx_seq_interface_fops);
 	if (!p)
 		goto out_interface;
 
-	p->proc_fops = &ipx_seq_interface_fops;
-	p = create_proc_entry("route", S_IRUGO, ipx_proc_dir);
+	p = proc_create("route", S_IRUGO, ipx_proc_dir, &ipx_seq_route_fops);
 	if (!p)
 		goto out_route;
 
-	p->proc_fops = &ipx_seq_route_fops;
-	p = create_proc_entry("socket", S_IRUGO, ipx_proc_dir);
+	p = proc_create("socket", S_IRUGO, ipx_proc_dir, &ipx_seq_socket_fops);
 	if (!p)
 		goto out_socket;
 
-	p->proc_fops = &ipx_seq_socket_fops;
-
 	rc = 0;
 out:
 	return rc;
-- 
WCN

Re: [PATCH 05/15] [IPX]: Use proc_create() to setup ->proc_fops first

From: David Miller <davem@davemloft.net>
Date: 2008-02-28 22:06:21

From: Wang Chen <redacted>
Date: Thu, 28 Feb 2008 18:56:23 +0800
Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.

Signed-off-by: Wang Chen <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help