[RTNL]: Add missing link netlink attribute policy definitions

2 messages, 2 authors, 2008-02-20 · open the first message on its own page

[RTNL]: Add missing link netlink attribute policy definitions

From: Thomas Graf <tgraf@suug.ch>
Date: 2008-02-20 00:14:48

IFLA_LINK is no longer a write-only attribute on the kernel
side and must thus be validated. Same goes for the newly
introduced IFLA_LINKINFO.

Fixes undefined behaviour if either of the attributes are
not well formed.

Signed-off-by: Thomas Graf <tgraf@suug.ch>

Index: net-2.6.26/net/core/rtnetlink.c
===================================================================
--- net-2.6.26.orig/net/core/rtnetlink.c	2008-02-19 20:30:08.000000000 +0100
+++ net-2.6.26/net/core/rtnetlink.c	2008-02-20 00:39:54.000000000 +0100
@@ -693,10 +693,12 @@
 	[IFLA_BROADCAST]	= { .type = NLA_BINARY, .len = MAX_ADDR_LEN },
 	[IFLA_MAP]		= { .len = sizeof(struct rtnl_link_ifmap) },
 	[IFLA_MTU]		= { .type = NLA_U32 },
+	[IFLA_LINK]		= { .type = NLA_U32 },
 	[IFLA_TXQLEN]		= { .type = NLA_U32 },
 	[IFLA_WEIGHT]		= { .type = NLA_U32 },
 	[IFLA_OPERSTATE]	= { .type = NLA_U8 },
 	[IFLA_LINKMODE]		= { .type = NLA_U8 },
+	[IFLA_LINKINFO]		= { .type = NLA_NESTED },
 	[IFLA_NET_NS_PID]	= { .type = NLA_U32 },
 };
 

Re: [RTNL]: Add missing link netlink attribute policy definitions

From: David Miller <davem@davemloft.net>
Date: 2008-02-20 00:11:41

From: Thomas Graf <tgraf@suug.ch>
Date: Wed, 20 Feb 2008 00:46:06 +0100
IFLA_LINK is no longer a write-only attribute on the kernel
side and must thus be validated. Same goes for the newly
introduced IFLA_LINKINFO.

Fixes undefined behaviour if either of the attributes are
not well formed.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Applied, thanks Thomas.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help