Re: [PATCH] macb: Fix speed setting

4 messages, 2 authors, 2008-02-21 · open the first message on its own page

Re: [PATCH] macb: Fix speed setting

From: Haavard Skinnemoen <hidden>
Date: 2008-02-21 14:13:13

On Thu, 21 Feb 2008 22:50:54 +0900 (JST)
Atsushi Nemoto [off-list ref] wrote:

quoted hunk

Fix NCFGR.SPD setting on 10Mbps.  This bug was introduced by
conversion to generic PHY layer in kernel 2.6.23.

Signed-off-by: Atsushi Nemoto <redacted>
---

diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 81bf005..1d210ed 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c

@@ -148,7 +148,7 @@ static void macb_handle_link_change(struct net_device *dev)
 
 			if (phydev->duplex)
 				reg |= MACB_BIT(FD);
-			if (phydev->speed)
+			if (phydev->speed == SPEED_100)

I have to admit that even after looking through include/linux/phy.h and
include/linux/mii.h, I don't have the faintest idea what values we can
expect to find in the "speed" field of phydev. The comment above struct
phy_device says that it is used "like in mii_if_info", but struct
mii_if_info doesn't have a "speed" field...

I'm willing to take your word for it, but some documentation would be
really nice...

Haavard

Re: [PATCH] macb: Fix speed setting

From: Atsushi Nemoto <hidden>
Date: 2008-02-21 15:04:20

On Thu, 21 Feb 2008 15:12:46 +0100, Haavard Skinnemoen [off-list ref] wrote:

I have to admit that even after looking through include/linux/phy.h and
include/linux/mii.h, I don't have the faintest idea what values we can
expect to find in the "speed" field of phydev. The comment above struct
phy_device says that it is used "like in mii_if_info", but struct
mii_if_info doesn't have a "speed" field...

I'm willing to take your word for it, but some documentation would be
really nice...

Well, simple grepping drivers/net/phy

Re: [PATCH] macb: Fix speed setting

From: Atsushi Nemoto <hidden>
Date: 2008-02-21 15:07:23

Excuse me for sending broken mail...

On Thu, 21 Feb 2008 15:12:46 +0100, Haavard Skinnemoen [off-list ref] wrote:

I have to admit that even after looking through include/linux/phy.h and
include/linux/mii.h, I don't have the faintest idea what values we can
expect to find in the "speed" field of phydev. The comment above struct
phy_device says that it is used "like in mii_if_info", but struct
mii_if_info doesn't have a "speed" field...

I'm willing to take your word for it, but some documentation would be
really nice...

Well, simple grepping drivers/net/phy enlighten us ;)

Anyway, this patch fixes problem with 10Mbps on AT91SAM9260 board.

---
Atsushi Nemoto

Re: [PATCH] macb: Fix speed setting

From: Haavard Skinnemoen <hidden>
Date: 2008-02-21 16:39:51

On Fri, 22 Feb 2008 00:07:31 +0900 (JST)
Atsushi Nemoto [off-list ref] wrote:

quoted

I'm willing to take your word for it, but some documentation would be
really nice...

Well, simple grepping drivers/net/phy enlighten us ;)

Yeah, the patch certainly looks correct as far as I can tell.

Anyway, this patch fixes problem with 10Mbps on AT91SAM9260 board.

Thanks. I'll pass it on.

Haavard

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help